From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 11/30] IGET: Stop EXT2 from using iget() and read_inode() Date: Tue, 2 Oct 2007 12:06:10 +0200 Message-ID: <20071002100610.GA25647@atrey.karlin.mff.cuni.cz> References: <20071001130921.29339.72876.stgit@warthog.procyon.org.uk> <20071001131018.29339.40931.stgit@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: hch@infradead.org, viro@ftp.linux.org.uk, torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: David Howells Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.31.123]:54777 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752116AbXJBKGM (ORCPT ); Tue, 2 Oct 2007 06:06:12 -0400 Content-Disposition: inline In-Reply-To: <20071001131018.29339.40931.stgit@warthog.procyon.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org > diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c > index 0079b2c..d8fb795 100644 > --- a/fs/ext2/inode.c > +++ b/fs/ext2/inode.c ... > + > + raw_inode = ext2_get_inode(inode->i_sb, ino, &bh); > if (IS_ERR(raw_inode)) > goto bad_inode; Hmm, why don't you use the return value from raw_inode? It can be either -EIO or -EINVAL if 'ino' was invalid... Otherwise the patch looks fine. Honza -- Jan Kara SuSE CR Labs