From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: linux-kernel@vger.kernel.org, dada1@cosmosbay.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [patch 1/2] getattr - fill the size of pipes
Date: Thu, 4 Oct 2007 16:22:52 -0700 [thread overview]
Message-ID: <20071004162252.f0785c9f.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0710021952450.7130@fbirervta.pbzchgretzou.qr>
On Tue, 2 Oct 2007 19:54:53 +0200 (CEST)
Jan Engelhardt <jengelh@computergmbh.de> wrote:
> [PATCH]: Fill the size of pipes
>
> Instead of reporting 0 in size when stating() a pipe, we give the number of
> queued bytes. This might avoid using ioctl(FIONREAD) to get this information.
>
> References and derived from: http://lkml.org/lkml/2007/4/2/138
> Cc: Eric Dumazet <dada1@cosmosbay.com>
> Signed-off-by: Jan Engelhardt <jengelh@gmx.de>
Cute feature, but it is (I assume) a Linux-specific extension and is
something which we'll need to maintain for ever and it invites
unportability to older Linuxes and other OSes and it introduces some risk
of breakage of existing applications. And it slows down fstat on a pipe.
Given that the info can already be obtained via ioctl(FIONREAD) anyway, I
don't think that (gain > pain)?
next prev parent reply other threads:[~2007-10-04 23:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 17:54 [patch 1/2] getattr - fill the size of pipes Jan Engelhardt
2007-10-02 17:55 ` [patch 2/2] getattr - fill the size of FIFOs Jan Engelhardt
2007-10-04 23:22 ` Andrew Morton [this message]
2007-10-04 23:41 ` [patch 1/2] getattr - fill the size of pipes Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004162252.f0785c9f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=jengelh@computergmbh.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).