From: Randy Dunlap <randy.dunlap@oracle.com>
To: David Howells <dhowells@redhat.com>
Cc: hch@infradead.org, viro@ftp.linux.org.uk, torvalds@osdl.org,
akpm@osdl.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 01/32] Add an ERR_CAST() macro to complement ERR_PTR and co. [try #2]
Date: Fri, 5 Oct 2007 09:21:29 -0700 [thread overview]
Message-ID: <20071005092129.8fae521d.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20071004155607.2814.74947.stgit@warthog.procyon.org.uk>
On Thu, 04 Oct 2007 16:56:07 +0100 David Howells wrote:
> Add an ERR_CAST() macro to complement ERR_PTR and co. for the purposes of
> casting an error entyped as one pointer type to an error of another pointer
> type whilst making it explicit as to what is going on.
>
> This provides a replacement for the ERR_PTR(PTR_ERR(p)) construct.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
>
> include/linux/err.h | 12 ++++++++++++
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/err.h b/include/linux/err.h
> index 1ab1d44..e810ca4 100644
> --- a/include/linux/err.h
> +++ b/include/linux/err.h
> @@ -34,6 +34,18 @@ static inline long IS_ERR(const void *ptr)
> return IS_ERR_VALUE((unsigned long)ptr);
> }
>
> +/**
> + * ERR_CAST - Explicitly cast an error-valued pointer to another pointer type
> + * ptr: The pointer to cast.
@ptr:
> + *
> + * Explicitly cast an error-valued pointer to another pointer type in such a
> + * way as to make it clear that's what's going on.
> + */
> +static inline void *ERR_CAST(const void *ptr)
> +{
> + return (void *) ptr;
> +}
> +
> #endif
>
> #endif /* _LINUX_ERR_H */
---
~Randy
next prev parent reply other threads:[~2007-10-05 16:22 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 15:56 [PATCH 00/32] Remove iget() and read_inode() [try #2] David Howells
2007-10-04 15:56 ` [PATCH 01/32] Add an ERR_CAST() macro to complement ERR_PTR and co. " David Howells
2007-10-05 14:46 ` Christoph Hellwig
2007-10-05 15:47 ` David Howells
2007-10-05 16:07 ` Sam Ravnborg
2007-10-05 16:19 ` David Howells
2007-10-05 16:21 ` Randy Dunlap [this message]
2007-10-04 15:56 ` [PATCH 02/32] Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p) " David Howells
2007-10-04 15:56 ` [PATCH 03/32] IGET: Introduce a function to register iget failure " David Howells
2007-10-05 14:47 ` Christoph Hellwig
2007-10-04 15:56 ` [PATCH 04/32] IGET: Use iget_failed() in AFS " David Howells
2007-10-04 15:56 ` [PATCH 05/32] IGET: Use iget_failed() in GFS2 " David Howells
2007-10-04 15:56 ` [PATCH 06/32] IGET: Mark iget() and read_inode() as being obsolete " David Howells
2007-10-05 14:47 ` Christoph Hellwig
2007-10-05 15:12 ` David Howells
2007-10-05 15:21 ` David Howells
2007-10-05 15:29 ` Christoph Hellwig
2007-10-04 15:56 ` [PATCH 07/32] IGET: Stop AFFS from using iget() and read_inode() " David Howells
2007-10-04 15:56 ` [PATCH 08/32] IGET: Stop autofs " David Howells
2007-10-04 15:56 ` [PATCH 09/32] IGET: Stop BEFS " David Howells
2007-10-04 15:56 ` [PATCH 10/32] IGET: Stop BFS " David Howells
2007-10-04 15:56 ` [PATCH 11/32] IGET: Stop CIFS " David Howells
2007-10-04 15:57 ` [PATCH 12/32] IGET: Stop EFS " David Howells
2007-10-04 15:57 ` [PATCH 13/32] IGET: Stop EXT2 " David Howells
2007-10-05 12:05 ` Theodore Tso
2007-10-04 15:57 ` [PATCH 14/32] IGET: Stop EXT3 " David Howells
2007-10-09 15:41 ` Jan Kara
2007-10-04 15:57 ` [PATCH 15/32] IGET: Stop EXT4 " David Howells
2007-10-09 15:45 ` Jan Kara
2007-10-04 15:57 ` [PATCH 16/32] IGET: Stop FAT " David Howells
2007-10-04 15:57 ` [PATCH 17/32] IGET: Stop FreeVXFS " David Howells
2007-10-04 15:57 ` [PATCH 18/32] IGET: Stop FUSE " David Howells
2007-10-04 15:57 ` [PATCH 19/32] IGET: Stop HFSPLUS " David Howells
2007-10-04 15:57 ` [PATCH 20/32] IGET: Stop ISOFS from using " David Howells
2007-10-04 15:57 ` [PATCH 21/32] IGET: Stop JFFS2 from using iget() and " David Howells
2007-10-04 15:57 ` [PATCH 22/32] IGET: Stop JFS " David Howells
2007-10-04 15:57 ` [PATCH 23/32] IGET: Stop the MINIX filesystem " David Howells
2007-10-04 15:58 ` [PATCH 24/32] IGET: Stop PROCFS " David Howells
2007-10-04 15:58 ` [PATCH 25/32] IGET: Stop QNX4 " David Howells
2007-10-04 15:58 ` [PATCH 26/32] IGET: Stop ROMFS " David Howells
2007-10-04 15:58 ` [PATCH 27/32] IGET: Stop the SYSV filesystem " David Howells
2007-10-04 15:58 ` [PATCH 28/32] IGET: Stop UFS " David Howells
2007-10-04 15:58 ` [PATCH 29/32] IGET: Stop OPENPROMFS " David Howells
2007-10-04 15:58 ` [PATCH 30/32] IGET: Stop HOSTFS " David Howells
2007-10-04 15:58 ` [PATCH 31/32] IGET: Stop HPPFS " David Howells
2007-10-04 15:58 ` [PATCH 32/32] IGET: Remove iget() and the read_inode() super op as being obsolete " David Howells
2007-10-05 14:44 ` [PATCH 00/32] Remove iget() and read_inode() " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071005092129.8fae521d.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).