From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Tso Subject: Re: [PATCH 13/32] IGET: Stop EXT2 from using iget() and read_inode() [try #2] Date: Fri, 5 Oct 2007 08:05:29 -0400 Message-ID: <20071005120529.GA28985@thunk.org> References: <20071004155602.2814.47731.stgit@warthog.procyon.org.uk> <20071004155708.2814.8998.stgit@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: hch@infradead.org, viro@ftp.linux.org.uk, torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: David Howells Return-path: Received: from THUNK.ORG ([69.25.196.29]:40628 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752135AbXJEMF6 (ORCPT ); Fri, 5 Oct 2007 08:05:58 -0400 Content-Disposition: inline In-Reply-To: <20071004155708.2814.8998.stgit@warthog.procyon.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Oct 04, 2007 at 04:57:08PM +0100, David Howells wrote: > Stop the EXT2 filesystem from using iget() and read_inode(). Replace > ext2_read_inode() with ext2_iget(), and call that instead of iget(). > ext2_iget() then uses iget_locked() directly and returns a proper error code > instead of an inode in the event of an error. > > ext2_fill_super() returns any error incurred when getting the root inode > instead of EINVAL. > > Signed-off-by: David Howells Acked-by: "Theodore Ts'o" - Ted