From: WANG Cong <xiyou.wangcong@gmail.com>
To: Yan Zheng <yanzheng@21cn.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH]fix VM_CAN_NONLINEAR check in sys_remap_file_pages
Date: Mon, 8 Oct 2007 19:52:36 +0800 [thread overview]
Message-ID: <20071008115236.GB2460@hacking> (raw)
In-Reply-To: <3d0408630710080445j4dea115emdfe29aac26814536@mail.gmail.com>
On Mon, Oct 08, 2007 at 07:45:08PM +0800, Yan Zheng wrote:
>Hi all
>
>The test for VM_CAN_NONLINEAR always fails
>
>Signed-off-by: Yan Zheng<yanzheng@21cn.com>
>----
>diff -ur linux-2.6.23-rc9/mm/fremap.c linux/mm/fremap.c
>--- linux-2.6.23-rc9/mm/fremap.c 2007-10-07 15:03:33.000000000 +0800
>+++ linux/mm/fremap.c 2007-10-08 19:33:44.000000000 +0800
>@@ -160,7 +160,7 @@
> if (vma->vm_private_data && !(vma->vm_flags & VM_NONLINEAR))
> goto out;
>
>- if (!vma->vm_flags & VM_CAN_NONLINEAR)
>+ if (!(vma->vm_flags & VM_CAN_NONLINEAR))
Good catch!
! operator has higher priority than & operator.
Acked by me. ;-)
> goto out;
>
> if (end <= start || start < vma->vm_start || end > vma->vm_end)
next prev parent reply other threads:[~2007-10-08 11:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 11:45 [PATCH]fix VM_CAN_NONLINEAR check in sys_remap_file_pages Yan Zheng
2007-10-08 11:52 ` WANG Cong [this message]
2007-10-08 13:37 ` Hugh Dickins
2007-10-08 6:47 ` Nick Piggin
2007-10-08 22:50 ` Yan Zheng
2007-10-08 17:04 ` Andrew Morton
2007-10-08 7:02 ` Nick Piggin
2007-10-08 17:28 ` Randy Dunlap
[not found] ` <20071008102843.d20b56d7.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2007-10-08 17:51 ` Andrew Morton
2007-10-08 7:45 ` Nick Piggin
2007-10-09 1:43 ` Yan Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071008115236.GB2460@hacking \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yanzheng@21cn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).