linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jaroslav Sykora <jara@sin.cvut.cz>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org
Subject: [RFC PATCH 3/5] Shadow directories: chdir, fchdir
Date: Thu, 18 Oct 2007 17:25:15 +0200	[thread overview]
Message-ID: <200710181725.15721.jara@sin.cvut.cz> (raw)
In-Reply-To: <200710181721.09201.jara@sin.cvut.cz>

sys_chdir and sys_fchdir changes.

Signed-off-by: Jaroslav Sykora <jaroslav.sykora@gmail.com>

 fs/open.c |   79 ++++++++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 73 insertions(+), 6 deletions(-)

--- orig/fs/open.c	2007-10-07 19:00:19.000000000 +0200
+++ new/fs/open.c	2007-10-16 21:04:56.000000000 +0200
@@ -476,13 +476,51 @@ asmlinkage long sys_access(const char __
 	return sys_faccessat(AT_FDCWD, filename, mode);
 }
 
+static inline int read_fs_flags(void)
+{
+	int res;
+	read_lock(&current->fs->lock);
+	res = current->fs->flags;
+	read_unlock(&current->fs->lock);
+	return res;
+}
+
+void set_fs_shdwpwd(struct fs_struct *fs,
+			struct vfsmount *mnt, struct dentry *dentry)
+{
+	struct dentry *old_dentry;
+	struct vfsmount *old_mnt;
+
+	BUG_ON(dentry != NULL && mnt == NULL);
+	write_lock(&fs->lock);
+	/* set shadow pwd */
+	old_dentry = fs->shdwpwd;
+	old_mnt = fs->shdwpwdmnt;
+	fs->shdwpwd = dget(dentry);
+	if (dentry)
+		fs->shdwpwdmnt = mntget(mnt);
+	else
+		/* PTR_ERR flag */
+		fs->shdwpwdmnt = mnt;
+	write_unlock(&fs->lock);
+
+	if (old_dentry) {
+		mntput(old_mnt);
+		dput(old_dentry);
+	}
+}
+
 asmlinkage long sys_chdir(const char __user * filename)
 {
 	struct nameidata nd;
-	int error;
+	char *tmp = getname(filename);
+	int error = PTR_ERR(tmp);;
+
+	if (IS_ERR(tmp))
+		goto out_badname;
 
-	error = __user_walk(filename,
-			    LOOKUP_FOLLOW|LOOKUP_DIRECTORY|LOOKUP_CHDIR, &nd);
+	error = path_lookup(tmp, LOOKUP_FOLLOW | LOOKUP_DIRECTORY
+			| LOOKUP_CHDIR, &nd);
 	if (error)
 		goto out;
 
@@ -490,11 +528,23 @@ asmlinkage long sys_chdir(const char __u
 	if (error)
 		goto dput_and_out;
 
-	set_fs_pwd(current->fs, nd.mnt, nd.dentry);
+	if (!(read_fs_flags() & SHDW_ENABLED))
+		goto set_std;
 
+	if (!(nd.flags & LOOKUP_INSHDW))
+		set_fs_shdwpwd(current->fs, NULL, NULL);
+	else
+		/* shadow == std */
+		set_fs_shdwpwd(current->fs, nd.mnt, nd.dentry);
+
+set_std:
+	/* set std cwd */
+	set_fs_pwd(current->fs, nd.mnt, nd.dentry);
 dput_and_out:
 	path_release(&nd);
 out:
+	putname(tmp);
+out_badname:
 	return error;
 }
 
@@ -520,8 +570,25 @@ asmlinkage long sys_fchdir(unsigned int 
 		goto out_putf;
 
 	error = file_permission(file, MAY_EXEC);
-	if (!error)
-		set_fs_pwd(current->fs, mnt, dentry);
+	if (error)
+		goto out_putf;
+
+	set_fs_pwd(current->fs, mnt, dentry);
+
+	if (!(read_fs_flags() & SHDW_ENABLED))
+		/* shadow dirs aren't enabled */
+		goto out_putf;
+
+	if (get_file_shdwdir(file, &dentry, &mnt))
+		/* some error ocured */
+		set_fs_shdwpwd(current->fs, NULL, NULL);
+	else {
+		/* ok */
+		set_fs_shdwpwd(current->fs, mnt, dentry);
+		mntput(mnt);
+		dput(dentry);
+	}
+
 out_putf:
 	fput(file);
 out:

  parent reply	other threads:[~2007-10-18 15:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-18 15:21 [RFC PATCH 0/5] Shadow directories Jaroslav Sykora
2007-10-18 15:22 ` [RFC PATCH 1/5] Shadow directories: headers Jaroslav Sykora
2007-10-18 15:23 ` [RFC PATCH 2/5] Shadow directories: core Jaroslav Sykora
2007-10-18 15:25 ` Jaroslav Sykora [this message]
2007-10-18 15:26 ` [RFC PATCH 4/5] Shadow directories: procfs Jaroslav Sykora
2007-10-18 15:28 ` [RFC PATCH 5/5] Shadow directories: documentation Jaroslav Sykora
2007-10-18 16:05 ` [RFC PATCH 0/5] Shadow directories Jan Engelhardt
2007-10-18 17:07   ` Jaroslav Sykora
2007-10-18 17:10     ` Jan Engelhardt
2007-10-18 20:10       ` Jaroslav Sykora
2007-10-18 20:12         ` Jan Engelhardt
     [not found]     ` <4717BBBB.6040205@davidnewall.com>
2007-10-18 20:09       ` Jan Engelhardt
2007-10-18 20:37       ` David Newall
2007-10-18 20:47         ` Al Viro
2007-10-19  2:57           ` David Newall
2007-10-19  5:37             ` Al Viro
2007-10-18 16:30 ` David Newall
2007-10-18 16:33   ` David Newall
2007-10-18 16:53     ` David Newall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710181725.15721.jara@sin.cvut.cz \
    --to=jara@sin.cvut.cz \
    --cc=jaroslav.sykora@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).