From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 1/9] Unionfs: security convert lsm into a static interface fix
Date: Mon, 22 Oct 2007 09:22:31 +0100
Message-ID: <20071022082231.GA15132@infradead.org>
References: <11930106823372-git-send-email-ezk@cs.sunysb.edu> <11930106831948-git-send-email-ezk@cs.sunysb.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk,
	hch@infradead.org, "Serge E. Hallyn" <serue@us.ibm.com>,
	Arjan van de Ven <arjan@infradead.org>,
	Chris Wright <chrisw@sous-sol.org>,
	James Morris <jmorris@namei.org>,
	Stephen Smalley <sds@tycho.nsa.gov>,
	Josef 'Jeff' Sipek <jsipek@cs.sunysb.edu>
To: Erez Zadok <ezk@cs.sunysb.edu>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from pentafluge.infradead.org ([213.146.154.40]:51975 "EHLO
	pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751258AbXJVIWw (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 22 Oct 2007 04:22:52 -0400
Content-Disposition: inline
In-Reply-To: <11930106831948-git-send-email-ezk@cs.sunysb.edu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Sun, Oct 21, 2007 at 07:51:14PM -0400, Erez Zadok wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> ERROR: "security_inode_permission" [fs/unionfs/unionfs.ko] undefined!
> ERROR: "security_file_ioctl" [fs/unionfs/unionfs.ko] undefined!
> 
> Need these back.

These should never used by modules.  You'll need to use and/or introduce
vfs_ helpers that do proper security checks before calling the methods.