From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fengguang Wu Subject: Re: [PATCH] reiserfs: don't drop PG_dirty when releasing sub-page-sized dirty file Date: Tue, 23 Oct 2007 22:40:14 +0800 Message-ID: <393150419.31806@ustc.edu.cn> References: <200710220822.52370.maximlevitsky@gmail.com> <200710221258.11384.maximlevitsky@gmail.com> <393051953.24752@ustc.edu.cn> <200710221421.21439.maximlevitsky@gmail.com> <393126119.26275@ustc.edu.cn> <1193134027.7406.1.camel@twins> <393140585.27414@ustc.edu.cn> <20071023101053.638fe207@think.oraclecorp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Peter Zijlstra , Maxim Levitsky , linux-kernel@vger.kernel.org, Andrew Morton , Jeff Mahoney , reiserfs-dev@namesys.com, linux-fsdevel@vger.kernel.org To: Chris Mason Return-path: Received: from smtp.ustc.edu.cn ([202.38.64.16]:60361 "HELO ustc.edu.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1751758AbXJWOkT (ORCPT ); Tue, 23 Oct 2007 10:40:19 -0400 Message-ID: <20071023144014.GA6174@mail.ustc.edu.cn> Content-Disposition: inline In-Reply-To: <20071023101053.638fe207@think.oraclecorp.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Oct 23, 2007 at 10:10:53AM -0400, Chris Mason wrote: > On Tue, 23 Oct 2007 19:56:20 +0800 > Fengguang Wu wrote: > > > On Tue, Oct 23, 2007 at 12:07:07PM +0200, Peter Zijlstra wrote: > > > [ adding reiserfs devs to the CC ] > > > > Thank you. > > > > This fix is kind of crude - even when it fixed Maxim's problem, and > > survived my stress testing of a lot of patching and kernel compiling. > > I'd be glad to see better solutions. > > This should be safe, reiserfs has the buffer heads themselves clean and > the page should get cleaned eventually. The cancel_dirty_page call was > just an optimization to be VM friendly. > -chris 'chris' as in fs/reiserfs/{inode.c,namei.c}, and now in btrfs/*? Nice to meet you ;-) Fengguang From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fengguang Wu Subject: Re: [PATCH] reiserfs: don't drop PG_dirty when releasing sub-page-sized dirty file Date: Tue, 23 Oct 2007 22:40:14 +0800 Message-ID: <20071023144014.GA6174__34720.1780452908$1193150464$gmane$org@mail.ustc.edu.cn> References: <200710220822.52370.maximlevitsky@gmail.com> <200710221258.11384.maximlevitsky@gmail.com> <393051953.24752@ustc.edu.cn> <200710221421.21439.maximlevitsky@gmail.com> <393126119.26275@ustc.edu.cn> <1193134027.7406.1.camel@twins> <393140585.27414@ustc.edu.cn> <20071023101053.638fe207@think.oraclecorp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Peter Zijlstra , Maxim Levitsky , linux-kernel@vger.kernel.org, Andrew Morton , Jeff Mahoney , reiserfs-dev@namesys.com, linux-fsdevel@vger.kernel.org To: Chris Mason Return-path: Message-ID: <20071023144014.GA6174@mail.ustc.edu.cn> Content-Disposition: inline In-Reply-To: <20071023101053.638fe207@think.oraclecorp.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Oct 23, 2007 at 10:10:53AM -0400, Chris Mason wrote: > On Tue, 23 Oct 2007 19:56:20 +0800 > Fengguang Wu wrote: > > > On Tue, Oct 23, 2007 at 12:07:07PM +0200, Peter Zijlstra wrote: > > > [ adding reiserfs devs to the CC ] > > > > Thank you. > > > > This fix is kind of crude - even when it fixed Maxim's problem, and > > survived my stress testing of a lot of patching and kernel compiling. > > I'd be glad to see better solutions. > > This should be safe, reiserfs has the buffer heads themselves clean and > the page should get cleaned eventually. The cancel_dirty_page call was > just an optimization to be VM friendly. > -chris 'chris' as in fs/reiserfs/{inode.c,namei.c}, and now in btrfs/*? Nice to meet you ;-) Fengguang