From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] fix tmpfs BUG and AOP_WRITEPAGE_ACTIVATE
Date: Wed, 24 Oct 2007 14:08:36 -0700
Message-ID: <20071024140836.a0098180.akpm@linux-foundation.org>
References: <Pine.LNX.4.64.0710142049000.13119@sbz-30.cs.Helsinki.FI>
	<200710142232.l9EMW8kK029572@agora.fsl.cs.sunysb.edu>
	<84144f020710150447o94b1babo8b6e6a647828465f@mail.gmail.com>
	<Pine.LNX.4.64.0710222101420.23513@blonde.wat.veritas.com>
	<Pine.LNX.4.64.0710242152020.13001@blonde.wat.veritas.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: penberg@cs.helsinki.fi, ezk@cs.sunysb.edu, ryan@finnie.org,
	mhalcrow@us.ibm.com, cjwatson@ubuntu.com,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, stable@kernel.org
To: Hugh Dickins <hugh@veritas.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtp2.linux-foundation.org ([207.189.120.14]:57591 "EHLO
	smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753819AbXJXVJV (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 24 Oct 2007 17:09:21 -0400
In-Reply-To: <Pine.LNX.4.64.0710242152020.13001@blonde.wat.veritas.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wed, 24 Oct 2007 22:02:15 +0100 (BST)
Hugh Dickins <hugh@veritas.com> wrote:

> --- 2.6.24-rc1/mm/shmem.c	2007-10-24 07:16:04.000000000 +0100
> +++ linux/mm/shmem.c	2007-10-24 20:24:31.000000000 +0100
> @@ -915,6 +915,11 @@ static int shmem_writepage(struct page *
>  	struct inode *inode;
>  
>  	BUG_ON(!PageLocked(page));
> +	if (!wbc->for_reclaim) {
> +		set_page_dirty(page);
> +		unlock_page(page);
> +		return 0;
> +	}
>  	BUG_ON(page_mapped(page));

Needs a comment, methinks.