From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and
 co. [try #5]
Date: Thu, 25 Oct 2007 16:46:58 -0700
Message-ID: <20071025164658.8fdc04cc.akpm@linux-foundation.org>
References: <20071025163352.5057.59344.stgit@warthog.procyon.org.uk>
	<20071025163357.5057.35399.stgit@warthog.procyon.org.uk>
	<47212215.8080003@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
To: Zach Brown <zach.brown@oracle.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtp2.linux-foundation.org ([207.189.120.14]:36642 "EHLO
	smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751684AbXJYXrW (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 25 Oct 2007 19:47:22 -0400
In-Reply-To: <47212215.8080003@oracle.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Thu, 25 Oct 2007 16:09:09 -0700
Zach Brown <zach.brown@oracle.com> wrote:

> 
> > + * ERR_CAST - Explicitly cast an error-valued pointer to another pointer type
> > + * @ptr: The pointer to cast.
> > + *
> > + * Explicitly cast an error-valued pointer to another pointer type in such a
> > + * way as to make it clear that's what's going on.
> > + */
> > +static inline void *ERR_CAST(const void *ptr)
> > +{
> > +	return (void *) ptr;
> > +}
> 
> Just to nit, surely you don't need the cast inside the function.  The
> casting happens at the call site between the argument and returned pointer.
> 

It'll warn without the cast.

btw, nit time.  This style:

	return (void *)ptr;

outnumbers this style

	return (void *) ptr;

by 4 to 1.  And I don't find the space attractive, useful or logical,
personally.