From: Mike Waychison <mikew@google.com>
To: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [patch 1/1] Drop CAP_SYS_RAWIO requirement for FIBMAP
Date: Thu, 25 Oct 2007 16:06:40 -0700 [thread overview]
Message-ID: <20071025230758.945535769@crlf.corp.google.com> (raw)
[-- Attachment #1: drop_cap_sys_rawio_for_fibmap.patch --]
[-- Type: text/plain, Size: 879 bytes --]
Remove the need for having CAP_SYS_RAWIO when doing a FIBMAP call on an open file descriptor.
It would be nice to allow users to have permission to see where their data is landing on disk, and there really isn't a good reason to keep them from getting at this information.
Signed-off-by: Mike Waychison <mikew@google.com>
fs/ioctl.c | 2 --
1 file changed, 2 deletions(-)
Index: linux-2.6.23/fs/ioctl.c
===================================================================
--- linux-2.6.23.orig/fs/ioctl.c 2007-10-09 13:31:38.000000000 -0700
+++ linux-2.6.23/fs/ioctl.c 2007-10-25 15:48:24.000000000 -0700
@@ -56,8 +56,6 @@ static int file_ioctl(struct file *filp,
/* do we support this mess? */
if (!mapping->a_ops->bmap)
return -EINVAL;
- if (!capable(CAP_SYS_RAWIO))
- return -EPERM;
if ((error = get_user(block, p)) != 0)
return error;
--
next reply other threads:[~2007-10-25 23:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 23:06 Mike Waychison [this message]
2007-10-26 0:22 ` [patch 1/1] Drop CAP_SYS_RAWIO requirement for FIBMAP Alan Cox
2007-10-26 0:35 ` Mike Waychison
2007-10-26 0:43 ` Alan Cox
2007-10-26 21:55 ` Jason Uhlenkott
2007-10-26 21:59 ` Mike Waychison
2007-10-26 22:40 ` Jason Uhlenkott
2007-10-26 22:53 ` Mike Waychison
2007-10-29 19:08 ` Pavel Machek
2007-11-01 14:51 ` Ric Wheeler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071025230758.945535769@crlf.corp.google.com \
--to=mikew@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).