From: Jeff Dike <jdike@addtoit.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] Fix linux/swap.h build wart
Date: Fri, 26 Oct 2007 17:49:10 -0400 [thread overview]
Message-ID: <20071026214910.GA11112@c2.user-mode-linux.org> (raw)
In-Reply-To: <617E1C2C70743745A92448908E030B2A02C9D4B6@scsmsx411.amr.corp.intel.com>
On Fri, Oct 26, 2007 at 01:38:12PM -0700, Luck, Tony wrote:
> Not fundamental reasons, but these patches break the ia64 build for most
> configs with:
>
> In file included from kernel/futex.c:59:
> include/asm/futex.h: In function `futex_atomic_op_inuser':
> include/asm/futex.h:62: error: implicit declaration of function `pagefault_disable'
> include/asm/futex.h:86: error: implicit declaration of function `pagefault_enable'
> make[1]: *** [kernel/futex.o] Error 1
>
> Adding an include of <linux/uaccess.h> to kernel/futex.c is sufficient (but
> not necessarily right) to unbreak this.
Yeah, I've been changing <asm/uaccess.h> to <linux/uaccess.h> for
these. Looks like I'll need to make a pass over all the futex.h's.
> A few configs also fail with:
> mm/migrate.c: In function `migrate_page_copy':
> mm/migrate.c:359: error: implicit declaration of function `copy_highpage'
> make[1]: *** [mm/migrate.o] Error 1
>
> Making mm/migrate.c include <linux/highmem.h> fixes this one.
Excellent, I hadn't yet figured out who used migrate.c.
Jeff
--
Work email - jdike at linux dot intel dot com
prev parent reply other threads:[~2007-10-26 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 19:25 [RFC PATCH 0/2] Fix linux/swap.h build wart Jeff Dike
2007-10-26 20:38 ` Luck, Tony
2007-10-26 21:49 ` Jeff Dike [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071026214910.GA11112@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).