From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mason Subject: Re: [patch 0/6][RFC] Cleanup FIBMAP Date: Mon, 29 Oct 2007 10:10:01 -0400 Message-ID: <20071029101001.4378a7cf@think.oraclecorp.com> References: <20071026233732.568575496@crlf.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Mike Waychison , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Anton Altaparmakov Return-path: Received: from agminet01.oracle.com ([141.146.126.228]:30816 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752279AbXJ2OMJ (ORCPT ); Mon, 29 Oct 2007 10:12:09 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, 27 Oct 2007 18:57:06 +0100 Anton Altaparmakov wrote: > Hi, > > ->bmap is ugly and horrible! If you have to do this at the very > least please cause ->bmap64 to be able to return error values in case > the file system failed to get the information or indeed such > information does not exist as is the case for compressed and > encrypted files for example and also for small files that are inside > the on-disk inode (NTFS resident files and reiserfs packed tails are > examples of this). > > And another of my pet peeves with ->bmap is that it uses 0 to mean > "sparse" which causes a conflict on NTFS at least as block zero is > part of the $Boot system file so it is a real, valid block... NTFS > uses -1 to denote sparse blocks internally. Reiserfs and Btrfs also use 0 to mean packed. It would be nice if there was a way to indicate your-data-is-here-but-isn't-alone. But that's more of a feature for the FIEMAP stuff. -chris