From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH 2/4] VFS: swap do_ioctl and vfs_ioctl names Date: Tue, 30 Oct 2007 08:22:40 -0700 Message-ID: <20071030082240.1ad71e6c.rdunlap@xenotime.net> References: <11936184581182-git-send-email-ezk@cs.sunysb.edu> <11936184592699-git-send-email-ezk@cs.sunysb.edu> <20071030095653.GC22413@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Erez Zadok , viro@ftp.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from xenotime.net ([66.160.160.81]:38831 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752074AbXJ3PWm (ORCPT ); Tue, 30 Oct 2007 11:22:42 -0400 Received: from midway.site ([71.117.233.180]) by xenotime.net for ; Tue, 30 Oct 2007 08:22:40 -0700 In-Reply-To: <20071030095653.GC22413@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 30 Oct 2007 09:56:53 +0000 Christoph Hellwig wrote: > On Sun, Oct 28, 2007 at 08:40:56PM -0400, Erez Zadok wrote: > > +/** > > + * vfs_ioctl - call filesystem specific ioctl methods > > + * > > + * @filp: [in] open file to invoke ioctl method on > > + * @cmd: [in] ioctl command to execute > > + * @arg: [in/out] command-specific argument for ioctl > > I've never seen these in/out annotations and doubt they're valid in > kerneldoc. Randy? They are just treated as part of the parameter explanation text. I don't see any problem with them. > > + * Invokes filesystem specific ->unlock_ioctl, if one exists; otherwise > > unlocked_ioctl --- ~Randy