From: Christoph Hellwig <hch@infradead.org>
To: Daniel Phillips <phillips@google.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Erez Zadok <ezk@cs.sunysb.edu>,
viro@ftp.linux.org.uk, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/3] VFS: apply coding standards to fs/ioctl.c
Date: Tue, 30 Oct 2007 09:55:48 +0000 [thread overview]
Message-ID: <20071030095548.GB22413@infradead.org> (raw)
In-Reply-To: <4d47a5d10710281957g1e423c1q6f45415d7465d90@mail.gmail.com>
On Sun, Oct 28, 2007 at 07:57:47PM -0700, Daniel Phillips wrote:
> On 10/28/07, Christoph Hellwig <hch@infradead.org> wrote:
> > While you're at it, it's probably worth splitting this out into
> > a small helper function.
>
> Why? Is the same pattern called from more than one place?
Becauase it's a lot more readable. ioctl subcommands are invidividual
functionality, and separating them out into small self-contained functions
makes the code a lot more readable.
next prev parent reply other threads:[~2007-10-30 9:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-27 23:10 [PATCH] 0/3 fs/ioctl.c coding style, rename vfs_ioctl/do_ioctl Erez Zadok
2007-10-27 23:10 ` [PATCH 1/3] VFS: apply coding standards to fs/ioctl.c Erez Zadok
2007-10-28 14:12 ` Christoph Hellwig
2007-10-28 18:05 ` Erez Zadok
2007-10-30 9:54 ` Christoph Hellwig
2007-10-29 2:57 ` Daniel Phillips
2007-10-30 9:55 ` Christoph Hellwig [this message]
2007-10-27 23:10 ` [PATCH 2/3] VFS: swap do_ioctl and vfs_ioctl names Erez Zadok
2007-10-28 14:14 ` Christoph Hellwig
2007-10-27 23:10 ` [PATCH 3/3] Unionfs: use vfs_ioctl Erez Zadok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030095548.GB22413@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ezk@cs.sunysb.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillips@google.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).