From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/3] VFS: apply coding standards to fs/ioctl.c Date: Tue, 30 Oct 2007 09:55:48 +0000 Message-ID: <20071030095548.GB22413@infradead.org> References: <11935266454097-git-send-email-ezk@cs.sunysb.edu> <11935266451616-git-send-email-ezk@cs.sunysb.edu> <20071028141222.GA29323@infradead.org> <4d47a5d10710281957g1e423c1q6f45415d7465d90@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Erez Zadok , viro@ftp.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Daniel Phillips Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:45628 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893AbXJ3Jz7 (ORCPT ); Tue, 30 Oct 2007 05:55:59 -0400 Content-Disposition: inline In-Reply-To: <4d47a5d10710281957g1e423c1q6f45415d7465d90@mail.gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sun, Oct 28, 2007 at 07:57:47PM -0700, Daniel Phillips wrote: > On 10/28/07, Christoph Hellwig wrote: > > While you're at it, it's probably worth splitting this out into > > a small helper function. > > Why? Is the same pattern called from more than one place? Becauase it's a lot more readable. ioctl subcommands are invidividual functionality, and separating them out into small self-contained functions makes the code a lot more readable.