From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/4] VFS: swap do_ioctl and vfs_ioctl names Date: Tue, 30 Oct 2007 09:56:53 +0000 Message-ID: <20071030095653.GC22413@infradead.org> References: <11936184581182-git-send-email-ezk@cs.sunysb.edu> <11936184592699-git-send-email-ezk@cs.sunysb.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: hch@infradead.org, viro@ftp.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Erez Zadok Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:45649 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754657AbXJ3J47 (ORCPT ); Tue, 30 Oct 2007 05:56:59 -0400 Content-Disposition: inline In-Reply-To: <11936184592699-git-send-email-ezk@cs.sunysb.edu> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sun, Oct 28, 2007 at 08:40:56PM -0400, Erez Zadok wrote: > +/** > + * vfs_ioctl - call filesystem specific ioctl methods > + * > + * @filp: [in] open file to invoke ioctl method on > + * @cmd: [in] ioctl command to execute > + * @arg: [in/out] command-specific argument for ioctl I've never seen these in/out annotations and doubt they're valid in kerneldoc. Randy? > + * Invokes filesystem specific ->unlock_ioctl, if one exists; otherwise unlocked_ioctl