From: Christoph Hellwig <hch@infradead.org>
To: Erez Zadok <ezk@cs.sunysb.edu>
Cc: hch@infradead.org, viro@ftp.linux.org.uk,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/4] VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls
Date: Tue, 30 Oct 2007 09:59:32 +0000 [thread overview]
Message-ID: <20071030095932.GD22413@infradead.org> (raw)
In-Reply-To: <11936184593537-git-send-email-ezk@cs.sunysb.edu>
> +static int __ioctl_fibmap(struct file *filp, int __user *p)
I'd say kill the __ prefix for all the functions you're adding.
> +static int __ioctl_fionbio(struct file *filp, unsigned long arg)
> +static int __ioctl_fioasync(unsigned int fd, struct file *filp,
> + unsigned long arg)
For these two I'd add a
void __user *argp = (void __user *)arg;
in the caller and then just pass argp down. That way we have the cast in
one place.
next prev parent reply other threads:[~2007-10-30 9:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 0:40 [PATCH] 0/4 fs/ioctl.c coding style, rename vfs_ioctl/do_ioctl, refactoring (take 2) Erez Zadok
2007-10-29 0:40 ` [PATCH 1/4] VFS: apply coding standards to fs/ioctl.c Erez Zadok
2007-10-29 0:40 ` [PATCH 2/4] VFS: swap do_ioctl and vfs_ioctl names Erez Zadok
2007-10-29 2:35 ` Randy Dunlap
2007-10-30 9:56 ` Christoph Hellwig
2007-10-30 15:22 ` Randy Dunlap
2007-10-30 17:14 ` Christoph Hellwig
2007-10-30 17:16 ` Randy Dunlap
2007-10-30 17:43 ` Erez Zadok
2007-10-29 0:40 ` [PATCH 3/4] VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls Erez Zadok
2007-10-30 9:59 ` Christoph Hellwig [this message]
2007-10-30 17:49 ` Erez Zadok
2007-10-30 17:57 ` Christoph Hellwig
2007-10-29 0:40 ` [PATCH 4/4] Unionfs: use vfs_ioctl Erez Zadok
-- strict thread matches above, loose matches on Subject: below --
2007-10-30 19:39 [PATCH v3] 0/4 fs/ioctl.c coding style, function renaming/factoring Erez Zadok
2007-10-30 19:39 ` [PATCH 3/4] VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls Erez Zadok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030095932.GD22413@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ezk@cs.sunysb.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).