From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 3/4] VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls
Date: Tue, 30 Oct 2007 09:59:32 +0000
Message-ID: <20071030095932.GD22413@infradead.org>
References: <11936184581182-git-send-email-ezk@cs.sunysb.edu> <11936184593537-git-send-email-ezk@cs.sunysb.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: hch@infradead.org, viro@ftp.linux.org.uk,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
To: Erez Zadok <ezk@cs.sunysb.edu>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from pentafluge.infradead.org ([213.146.154.40]:43057 "EHLO
	pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752029AbXJ3J7j (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 30 Oct 2007 05:59:39 -0400
Content-Disposition: inline
In-Reply-To: <11936184593537-git-send-email-ezk@cs.sunysb.edu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

> +static int __ioctl_fibmap(struct file *filp, int __user *p)

I'd say kill the __ prefix for all the functions you're adding.

> +static int __ioctl_fionbio(struct file *filp, unsigned long arg)

> +static int __ioctl_fioasync(unsigned int fd, struct file *filp,
> +			    unsigned long arg)

For these two I'd add a

	void __user *argp = (void __user *)arg;

in the caller and then just pass argp down.  That way we have the cast in
one place.