Re: + embed-a-struct-path-into-struct-nameidata-instead-of-nd-dentrymnt.patch added to -mm tree

["Jörn Engel" <joern@logfs.org>]

On Mon, 5 November 2007 13:01:25 -0800, akpm@linux-foundation.org wrote:
> 
> The patch titled
>      Embed a struct path into struct nameidata instead of nd->{dentry,mnt}
> has been added to the -mm tree.  Its filename is
>      embed-a-struct-path-into-struct-nameidata-instead-of-nd-dentrymnt.patch
> 
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
> 
> See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
> out what to do about this
> 
> ------------------------------------------------------
> Subject: Embed a struct path into struct nameidata instead of nd->{dentry,mnt}
> From: Jan Blunck <jblunck@suse.de>
> 
> Switch from nd->{dentry,mnt} to nd->path.{dentry,mnt} everywhere.
> 
> Signed-off-by: Jan Blunck <jblunck@suse.de>
> Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
> Acked-by: Christoph Hellwig <hch@lst.de>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> CC: <linux-fsdevel@vger.kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Frowned-upon-by: Joern Engel <joern@logfs.org>

This patch changes some 400 lines, most if not all of which get longer
and more complicated to read.  23 get sufficiently longer to require an
additional linebreak.  I can't remember complexity being invited into
the kernel without good reasoning, yet the patch description is
surprisingly low on reasoning:
> Switch from nd->{dentry,mnt} to nd->path.{dentry,mnt} everywhere.

The following two patches manage to remove 7 lines in total.  In total
23 were added, 7 removed , 400+ made longer and more complicated.  Is
there another more favorable metric?  Will this patchset prevent bugs?
Shrink the kernel size?  Anything?

If churn is the only effect of this, please considere it NAKed again.

Jörn

-- 
A surrounded army must be given a way out.
-- Sun Tzu
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html