From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 16/31] IGET: Stop FreeVXFS from using iget() and read_inode() [try #5] Date: Tue, 6 Nov 2007 02:25:05 -0800 Message-ID: <20071106022505.f32b1bff.akpm@linux-foundation.org> References: <20071025163352.5057.59344.stgit@warthog.procyon.org.uk> <20071025163514.5057.4558.stgit@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: David Howells Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:52700 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752045AbXKFKZw (ORCPT ); Tue, 6 Nov 2007 05:25:52 -0500 In-Reply-To: <20071025163514.5057.4558.stgit@warthog.procyon.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 25 Oct 2007 17:35:14 +0100 David Howells wrote: > Stop the FreeVXFS filesystem from using iget() and read_inode(). Replace > vxfs_read_inode() with vxfs_iget(), and call that instead of iget(). > vxfs_iget() then uses iget_locked() directly and returns a proper error code > instead of an inode in the event of an error. > > vxfs_fill_super() returns any error incurred when getting the root inode > instead of EINVAL. alpha: fs/freevxfs/vxfs_inode.c:298: error: conflicting types for 'vxfs_iget' fs/freevxfs/vxfs_extern.h:61: error: previous declaration of 'vxfs_iget' was here Not completely trivial - the ino_t -> unsigned long conversion needs to be propagated fairly widely in there. (when should we be using ino_t and when should we be using unsigned long, anyway?)