From: Alexander Viro <aviro@redhat.com>
To: Benny Halevy <bhalevy@panasas.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Steve Dickson <SteveD@redhat.com>,
Alexander Viro <aviro@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
nfs@lists.sourceforge.net,
"J. Bruce Fields" <bfields@fieldses.org>,
Trond Myklebust <trond.myklebust@fys.uio.no>
Subject: Re: [PATCH] NFS: Stop sillyname renames and unmounts from racing
Date: Tue, 6 Nov 2007 03:50:26 -0500 [thread overview]
Message-ID: <20071106085026.GB5397@devserv.devel.redhat.com> (raw)
In-Reply-To: <473024D2.6080105@panasas.com>
On Tue, Nov 06, 2007 at 10:24:50AM +0200, Benny Halevy wrote:
> It'd be very nice if the silly renamed inodes (with silly_count > 1) were moved
> to a different list in the first pass, under the inode_lock, and then waited on
> until silly_count <= 1 in a second pass only on the filtered list. This will
> provide you with O(1).
It's absolutely pointless, starting with any kind of searching for inodes,
etc. If you want fs shutdown _not_ to happen until async activity of
that kind is over, don't reinvent the sodding wheels, just tell VFS that
you are holding an active reference to superblock. End of story.
prev parent reply other threads:[~2007-11-06 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-03 11:09 [PATCH] NFS: Stop sillyname renames and unmounts from racing Steve Dickson
2007-11-06 5:06 ` Andrew Morton
2007-11-06 5:15 ` Alexander Viro
2007-11-08 9:05 ` Steve Dickson
2007-11-06 8:24 ` Benny Halevy
2007-11-06 8:50 ` Alexander Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071106085026.GB5397@devserv.devel.redhat.com \
--to=aviro@redhat.com \
--cc=SteveD@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=bhalevy@panasas.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).