From: "Jörn Engel" <joern@logfs.org>
To: Andi Drebes <lists-receive@programmierforen.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, Karel Zak <kzak@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
Phillip Lougher <phillip@lougher.demon.co.uk>
Subject: Re: [PATCH 1/2] Make cramfs little endian only
Date: Tue, 4 Dec 2007 16:34:28 +0100 [thread overview]
Message-ID: <20071204153428.GA23249@lazybastard.org> (raw)
In-Reply-To: <200712041301.27285.lists-receive@programmierforen.de>
On Tue, 4 December 2007 13:01:26 +0100, Andi Drebes wrote:
>
> +#ifdef __BIG_ENDIAN
> +/* Converts a cramfs_info from little endian to big endian. */
> +static inline void cramfs_convert_info_letobe(struct cramfs_info* info)
> +{
> + info->crc = swab32(info->crc);
> + info->edition = swab32(info->edition);
> + info->blocks = swab32(info->blocks);
> + info->files = swab32(info->files);
> +}
Can you remove the #ifdef and use le32_to_cpu() directly?
Jörn
--
Mundie uses a textbook tactic of manipulation: start with some
reasonable talk, and lead the audience to an unreasonable conclusion.
-- Bruce Perens
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-12-04 15:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 11:59 [PATCH 0/2] Make cramfs little endian only Andi Drebes
2007-12-04 12:01 ` [PATCH 1/2] " Andi Drebes
2007-12-04 15:34 ` Jörn Engel [this message]
2007-12-04 20:37 ` Andi Drebes
2007-12-04 20:58 ` Linus Torvalds
2007-12-04 21:31 ` Andi Drebes
2007-12-04 22:35 ` Linus Torvalds
2007-12-04 22:58 ` Jeff Garzik
2007-12-05 21:57 ` Andi Drebes
2007-12-05 22:21 ` Linus Torvalds
2007-12-05 22:41 ` Jörn Engel
2007-12-06 16:38 ` Andi Drebes
2007-12-06 16:27 ` Andi Drebes
2007-12-06 16:47 ` Jörn Engel
2007-12-06 17:35 ` Linus Torvalds
2007-12-06 17:31 ` Linus Torvalds
2007-12-06 22:37 ` Andi Drebes
2007-12-04 20:11 ` Andrew Morton
2007-12-04 20:58 ` Andi Drebes
2007-12-04 12:02 ` [PATCH 2/2] Update documentation Andi Drebes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071204153428.GA23249@lazybastard.org \
--to=joern@logfs.org \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=kzak@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lists-receive@programmierforen.de \
--cc=phillip@lougher.demon.co.uk \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).