From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?SsO2cm4=?= Engel Subject: Re: [PATCH 1/2] Make cramfs little endian only Date: Tue, 4 Dec 2007 16:34:28 +0100 Message-ID: <20071204153428.GA23249@lazybastard.org> References: <200712041259.52118.lists-receive@programmierforen.de> <200712041301.27285.lists-receive@programmierforen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Linus Torvalds , linux-fsdevel@vger.kernel.org, Karel Zak , Andrew Morton , Christoph Hellwig , Phillip Lougher To: Andi Drebes Return-path: Received: from lazybastard.de ([212.112.238.170]:33521 "EHLO longford.lazybastard.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753859AbXLDPj4 (ORCPT ); Tue, 4 Dec 2007 10:39:56 -0500 Content-Disposition: inline In-Reply-To: <200712041301.27285.lists-receive@programmierforen.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 4 December 2007 13:01:26 +0100, Andi Drebes wrote: > =20 > +#ifdef __BIG_ENDIAN > +/* Converts a cramfs_info from little endian to big endian. */ > +static inline void cramfs_convert_info_letobe(struct cramfs_info* in= fo) > +{ > + info->crc =3D swab32(info->crc); > + info->edition =3D swab32(info->edition); > + info->blocks =3D swab32(info->blocks); > + info->files =3D swab32(info->files); > +} Can you remove the #ifdef and use le32_to_cpu() directly? J=C3=B6rn --=20 Mundie uses a textbook tactic of manipulation: start with some reasonable talk, and lead the audience to an unreasonable conclusion. -- Bruce Perens - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html