linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Oren Laadan <orenl@cs.columbia.edu>
Cc: "Serge E. Hallyn" <serue@us.ibm.com>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	linux-fsdevel@vger.kernel.org,
	Linux Containers <containers@lists.osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch 1/2] [RFC] Simple tamper-proof device filesystem.
Date: Mon, 17 Dec 2007 20:09:33 -0600	[thread overview]
Message-ID: <20071218020933.GA28745@sergelap.austin.ibm.com> (raw)
In-Reply-To: <476724E3.6060901@cs.columbia.edu>

Quoting Oren Laadan (orenl@cs.columbia.edu):
> 
> I hate to bring this again, but what if the admin in the container
> mounts an external file system (eg. nfs, usb, loop mount from a file,
> or via fuse), and that file system already has a device that we would
> like to ban inside that container ?

Miklos' user mount patches enforced that if !capable(CAP_MKNOD),
then mnt->mnt_flags |= MNT_NODEV.  So that's no problem.

But that's been pulled out of -mm! ?  Crap.

> Since anyway we will have to keep a white- (or black-) list of devices
> that are permitted in a container, and that list may change even change
> per container -- why not enforce the access control at the VFS layer ?
> It's safer in the long run.

By that you mean more along the lines of Pavel's patch than my whitelist
LSM, or you actually mean Tetsuo's filesystem (i assume you don't mean that
by 'vfs layer' :), or something different entirely?

thanks,
-serge

  reply	other threads:[~2007-12-18  2:09 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071216080441.435456586@I-love.SAKURA.ne.jp>
     [not found] ` <20071216080628.061470932@I-love.SAKURA.ne.jp>
2007-12-16 10:44   ` [patch 0/2] [RFC] Simple tamper-proof device filesystem Tetsuo Handa
2007-12-16 10:56     ` [patch 1/2] " Tetsuo Handa
2007-12-06 15:29       ` Pavel Machek
2007-12-18 15:55         ` Valdis.Kletnieks
2007-12-18 16:43           ` Casey Schaufler
2007-12-16 11:21       ` David Newall
2007-12-16 11:26         ` Tetsuo Handa
2007-12-16 11:31           ` David Newall
2007-12-16 11:36             ` Tetsuo Handa
2007-12-16 11:58               ` David Newall
2007-12-16 12:03                 ` Tetsuo Handa
2007-12-16 12:14                   ` Tetsuo Handa
2007-12-17  6:00                     ` David Newall
2007-12-18 15:33                       ` Radoslaw Szkodzinski
2007-12-16 16:52                   ` Indan Zupancic
2007-12-16 19:48                     ` Al Viro
2007-12-17  0:40                     ` Tetsuo Handa
2007-12-17 11:44                       ` Indan Zupancic
2007-12-17 12:59                         ` Tetsuo Handa
2007-12-17 13:05                         ` Al Boldi
2007-12-17 13:16                           ` Tetsuo Handa
2007-12-18 15:22                           ` Radoslaw Szkodzinski
2007-12-19 12:11                             ` Tetsuo Handa
2007-12-19 19:14                               ` Radoslaw Szkodzinski
2007-12-17 13:32                         ` Tetsuo Handa
2007-12-17  6:42                     ` penguin-kernel
2007-12-17 19:48       ` Serge E. Hallyn
     [not found]         ` <20071217194802.GA14156-6s5zFf/epYLPQpwDFJZrxKsjOiXwFzmk@public.gmane.org>
2007-12-18  0:03           ` Tetsuo Handa
2007-12-18  0:39             ` Serge E. Hallyn
2007-12-18  1:39               ` Oren Laadan
2007-12-18  2:09                 ` Serge E. Hallyn [this message]
2007-12-18  3:04                   ` Oren Laadan
2007-12-19  9:43                     ` Pavel Emelyanov
2007-12-19 14:10                       ` Serge E. Hallyn
2007-12-20  0:07                         ` Oren Laadan
2007-12-20  7:42                           ` Pavel Emelyanov
2007-12-20 14:09                             ` Serge E. Hallyn
     [not found]                             ` <476A1CE0.30505-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2007-12-21  1:47                               ` Oren Laadan
2007-12-19 14:13                     ` Serge E. Hallyn
2007-12-18  1:55               ` Serge E. Hallyn
2007-12-18  2:26                 ` Tetsuo Handa
2007-12-18  2:53                   ` serge
2007-12-18  3:40                     ` Tetsuo Handa
2007-12-19 23:43       ` Serge E. Hallyn
2007-12-24 13:09         ` Tetsuo Handa
2007-12-16 11:03     ` [patch 2/2] " Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071218020933.GA28745@sergelap.austin.ibm.com \
    --to=serue@us.ibm.com \
    --cc=containers@lists.osdl.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=orenl@cs.columbia.edu \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).