From: Christoph Lameter <clameter@sgi.com>
To: akpm@linux-foundation.org
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Cc: David Chinner <dgc@sgi.com>
Subject: [patch 06/18] Use page_cache_xxx in mm/filemap_xip.c
Date: Wed, 26 Dec 2007 21:32:52 -0800 [thread overview]
Message-ID: <20071227053400.975702729@sgi.com> (raw)
In-Reply-To: 20071227053246.902699851@sgi.com
[-- Attachment #1: 0007-Use-page_cache_xxx-in-mm-filemap_xip.c.patch --]
[-- Type: text/plain, Size: 2971 bytes --]
Use page_cache_xxx in mm/filemap_xip.c
Reviewed-by: Dave Chinner <dgc@sgi.com>
Signed-off-by: Christoph Lameter <clameter@sgi.com>
---
mm/filemap_xip.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
Index: linux-2.6.24-rc6-mm1/mm/filemap_xip.c
===================================================================
--- linux-2.6.24-rc6-mm1.orig/mm/filemap_xip.c 2007-12-26 20:06:34.799489470 -0800
+++ linux-2.6.24-rc6-mm1/mm/filemap_xip.c 2007-12-26 20:06:58.159627986 -0800
@@ -61,24 +61,24 @@ do_xip_mapping_read(struct address_space
BUG_ON(!mapping->a_ops->get_xip_page);
- index = *ppos >> PAGE_CACHE_SHIFT;
- offset = *ppos & ~PAGE_CACHE_MASK;
+ index = page_cache_index(mapping, *ppos);
+ offset = page_cache_offset(mapping, *ppos);
isize = i_size_read(inode);
if (!isize)
goto out;
- end_index = (isize - 1) >> PAGE_CACHE_SHIFT;
+ end_index = page_cache_index(mapping, isize - 1);
for (;;) {
struct page *page;
unsigned long nr, ret;
/* nr is the maximum number of bytes to copy from this page */
- nr = PAGE_CACHE_SIZE;
+ nr = page_cache_size(mapping);
if (index >= end_index) {
if (index > end_index)
goto out;
- nr = ((isize - 1) & ~PAGE_CACHE_MASK) + 1;
+ nr = page_cache_next(mapping, isize);
if (nr <= offset) {
goto out;
}
@@ -117,8 +117,8 @@ do_xip_mapping_read(struct address_space
*/
ret = actor(desc, page, offset, nr);
offset += ret;
- index += offset >> PAGE_CACHE_SHIFT;
- offset &= ~PAGE_CACHE_MASK;
+ index += page_cache_index(mapping, offset);
+ offset = page_cache_offset(mapping, offset);
if (ret == nr && desc->count)
continue;
@@ -131,7 +131,7 @@ no_xip_page:
}
out:
- *ppos = ((loff_t) index << PAGE_CACHE_SHIFT) + offset;
+ *ppos = page_cache_pos(mapping, index, offset);
if (filp)
file_accessed(filp);
}
@@ -220,7 +220,7 @@ static int xip_file_fault(struct vm_area
/* XXX: are VM_FAULT_ codes OK? */
- size = (i_size_read(inode) + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT;
+ size = page_cache_next(mapping, i_size_read(inode));
if (vmf->pgoff >= size)
return VM_FAULT_SIGBUS;
@@ -290,9 +290,9 @@ __xip_file_write(struct file *filp, cons
size_t copied;
char *kaddr;
- offset = (pos & (PAGE_CACHE_SIZE -1)); /* Within page */
- index = pos >> PAGE_CACHE_SHIFT;
- bytes = PAGE_CACHE_SIZE - offset;
+ offset = page_cache_offset(mapping, pos); /* Within page */
+ index = page_cache_index(mapping, pos);
+ bytes = page_cache_size(mapping) - offset;
if (bytes > count)
bytes = count;
@@ -403,8 +403,8 @@ EXPORT_SYMBOL_GPL(xip_file_write);
int
xip_truncate_page(struct address_space *mapping, loff_t from)
{
- pgoff_t index = from >> PAGE_CACHE_SHIFT;
- unsigned offset = from & (PAGE_CACHE_SIZE-1);
+ pgoff_t index = page_cache_index(mapping, from);
+ unsigned offset = page_cache_offset(mapping, from);
unsigned blocksize;
unsigned length;
struct page *page;
--
next prev parent reply other threads:[~2007-12-27 5:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-27 5:32 [patch 00/18] Page cache: Replace PAGE_CACHE_xx with inline functions V3 Christoph Lameter
2007-12-27 5:32 ` [patch 01/18] Define functions for page cache handling Christoph Lameter
2007-12-27 5:32 ` [patch 02/18] Use page_cache_xxx functions in mm/filemap.c Christoph Lameter
2007-12-27 5:32 ` [patch 03/18] Use page_cache_xxx in mm/page-writeback.c Christoph Lameter
2007-12-27 5:32 ` [patch 04/18] Use page_cache_xxx in mm/truncate.c Christoph Lameter
2007-12-27 5:32 ` [patch 05/18] Use page_cache_xxx in mm/rmap.c Christoph Lameter
2007-12-27 5:32 ` Christoph Lameter [this message]
2007-12-27 5:32 ` [patch 07/18] Use page_cache_xxx in mm/migrate.c Christoph Lameter
2007-12-27 5:32 ` [patch 08/18] Use page_cache_xxx in fs/libfs.c Christoph Lameter
2007-12-27 5:32 ` [patch 09/18] Use page_cache_xxx in fs/sync Christoph Lameter
2007-12-27 5:32 ` [patch 10/18] Use page_cache_xxx in fs/buffer.c Christoph Lameter
2007-12-27 5:32 ` [patch 11/18] Use page_cache_xxx in mm/mpage.c Christoph Lameter
2007-12-27 5:32 ` [patch 12/18] Use page_cache_xxx in mm/fadvise.c Christoph Lameter
2007-12-27 5:32 ` [patch 13/18] Use page_cache_xxx in fs/splice.c Christoph Lameter
2007-12-27 5:33 ` [patch 14/18] Use page_cache_xxx in ext2 Christoph Lameter
2007-12-27 5:33 ` [patch 15/18] Use page_cache_xxx in fs/ext3 Christoph Lameter
2007-12-27 5:33 ` [patch 16/18] Use page_cache_xxx in fs/ext4 Christoph Lameter
2007-12-27 5:33 ` [patch 17/18] Use page_cache_xxx in fs/reiserfs Christoph Lameter
2007-12-27 5:33 ` [patch 18/18] Use page_cache_xxx for fs/xfs Christoph Lameter
-- strict thread matches above, loose matches on Subject: below --
2008-02-16 0:47 [patch 00/18] Page cache: Replace PAGE_CACHE_xx with inline functions V4 Christoph Lameter
2008-02-16 0:47 ` [patch 06/18] Use page_cache_xxx in mm/filemap_xip.c Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071227053400.975702729@sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).