From: Matthew Wilcox <matthew@wil.cx>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [RFC] Remove BKL from fs/locks.c
Date: Sun, 30 Dec 2007 07:42:42 -0700 [thread overview]
Message-ID: <20071230144241.GT11638@parisc-linux.org> (raw)
In-Reply-To: <20071230203644.00675d5a.sfr@canb.auug.org.au>
On Sun, Dec 30, 2007 at 08:36:44PM +1100, Stephen Rothwell wrote:
> We should probably do some performance testing on this because the last
> time we tried the impact was quite noticeable. You should ping Tridge as
> he has some good lock testing setups. And he cares if we slow him down :-)
Last time I did this, I switched to a semaphore instead of a spinlock.
That was what slowed us down. I doubt we can see a performance loss
with this patch since it's a 1-1 substitution of the BKL spinlock with a
private spinlock.
Good idea about asking tridge for an evaluation of the patch though.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-12-30 14:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-30 6:16 [RFC] Remove BKL from fs/locks.c Matthew Wilcox
2007-12-30 9:36 ` Stephen Rothwell
2007-12-30 14:42 ` Matthew Wilcox [this message]
2007-12-31 0:47 ` Stephen Rothwell
2007-12-30 13:05 ` Christoph Hellwig
2007-12-30 14:51 ` Matthew Wilcox
2007-12-30 15:17 ` Andi Kleen
2007-12-30 18:44 ` Trond Myklebust
2007-12-30 19:18 ` Andi Kleen
2007-12-30 19:23 ` Trond Myklebust
2008-01-04 23:41 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071230144241.GT11638@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).