From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [linux-cifs-client] review 4, was Re: projected date for mount.cifs to support DFS junction points Date: Mon, 14 Jan 2008 21:53:35 +0000 Message-ID: <20080114215335.GA26492@infradead.org> References: <1199988975.7483.3.camel@gn2.draper.com> <524f69650801101228o3639363cp4c9710d747b71ead@mail.gmail.com> <20080111090749.GA14910@infradead.org> <524f69650801110805y56cdbe4nf7587e396b70f32c@mail.gmail.com> <20080113201903.GA24573@infradead.org> <478B6059.2000204@mail.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Steve French , linux-fsdevel , linux-cifs-client@lists.samba.org, dhowells@redhat.com To: "Q (Igor Mammedov)" Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:46254 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754400AbYANVxk (ORCPT ); Mon, 14 Jan 2008 16:53:40 -0500 Content-Disposition: inline In-Reply-To: <478B6059.2000204@mail.ru> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jan 14, 2008 at 04:15:05PM +0300, Q (Igor Mammedov) wrote: > > + dput(nd->dentry); > > + nd->dentry = dget(dentry); > > + if (d_mountpoint(nd->dentry)) > > + goto out_follow; > > > > A link should never be a mountpoint. > > why link? after patch 5 are applied DFS junction point becomes directory > instead of link. That is what has been done in NFS code. True, this is the ->follow_link on directory hack. > Actually I copy & pasted it from NFS code ... > fs/nfs/namespace.c:nfs_follow_mountpoint > > I've tried to do submount/referral machinery in NFS code way. Okay, and that came from afs. I really think we should take large parts of this back into the VFS because it's just to fragile to be duplicated in various filesystems. Probably not a blocker for your patch but I'll keep an eye on consolidating this back into the core.