From: Christoph Hellwig <hch@infradead.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Pekka J Enberg <penberg@cs.helsinki.fi>,
alan@redhat.com, viro@zeniv.linux.org.uk, hch@infradead.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC/PATCH 4/8] revoke: core code V7
Date: Tue, 15 Jan 2008 17:27:41 +0000 [thread overview]
Message-ID: <20080115172741.GA20388@infradead.org> (raw)
In-Reply-To: <1200410094.26045.29.camel@twins>
On Tue, Jan 15, 2008 at 04:14:54PM +0100, Peter Zijlstra wrote:
> Humm, we were trying to get rid of file_list_lock(), this puts up
> another user of the sb file list.
>
> Also, that loop looks horribly expensive: n*(1+m); where n is the list
> size, and m the number of matching fds.
>
> Granted, I see no other options either.
Something like the loop above is not going to go in for sure. Once we
get rid of the sb->s_files we can put the list_head in struct file to
new use eventually if we don't want to get rid of it. E.g. and
per-inode list would be much better than the per-superblock one and
would regularize what the tty driver is doing.
But I'm not too interesting in hashing out these details currently,
my primary concern is to get the per-mount r/o plus fallout like the
correct remount r/o and file_list_lock removal in and stable first.
next prev parent reply other threads:[~2008-01-15 17:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 15:16 [RFC/PATCH 4/8] revoke: core code V7 Pekka J Enberg
2008-01-15 15:14 ` Peter Zijlstra
2008-01-15 17:27 ` Christoph Hellwig [this message]
2008-01-16 8:35 ` Pekka J Enberg
2008-04-13 20:43 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080115172741.GA20388@infradead.org \
--to=hch@infradead.org \
--cc=alan@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).