From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, jack@suse.cz
Subject: Re: [patch 25/26] mount options: fix udf
Date: Fri, 25 Jan 2008 16:41:58 +0300 [thread overview]
Message-ID: <20080125134158.GA7233@cvg> (raw)
In-Reply-To: <E1JIKsD-0001Kf-Bz@pomaz-ex.szeredi.hu>
[Miklos Szeredi - Fri, Jan 25, 2008 at 10:29:21AM +0100]
| > | + /* is this correct? */
| > | + if (sbi->s_anchor[2] != 0)
| > | + seq_printf(seq, ",anchor=%u", sbi->s_anchor[2]);
| >
| > you know, I would prefer to use form UDF_SB_ANCHOR(sb)[2]
| > in sake of style unification but we should wait for Jan's
| > decision (i'm not the expert in this area ;)
|
| I think UDF_SB_ANCHOR macro was removed by some patch in -mm.
|
| I'm more interested if the second element of the s_anchor array really
| does always have the value of the 'anchor=N' mount option. I haven't
| been able to verify that fully. Do you have some insight into that?
|
| Thanks,
| Miklos
|
Hello Miklos,
well, actually - no. anchor entities can be set to 0 if we have been failed
to read them in udf_find_anchor(). So it seems you've to use some
additional flag to store it.
Btw, Miklos the patch is over -mm tree?
- Cyrill -
next prev parent reply other threads:[~2008-01-25 13:42 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 19:33 [patch 00/26] mount options: fix filesystem's ->show_options Miklos Szeredi
2008-01-24 19:33 ` [patch 01/26] mount options: add documentation Miklos Szeredi
2008-01-25 0:24 ` Erez Zadok
2008-01-25 7:56 ` David Chinner
2008-01-25 10:02 ` Miklos Szeredi
2008-01-30 1:54 ` Roman Zippel
2008-01-30 9:09 ` Miklos Szeredi
2008-01-30 14:42 ` Karel Zak
2008-01-31 17:42 ` Miklos Szeredi
2008-02-08 19:20 ` Roman Zippel
2008-02-08 20:23 ` Miklos Szeredi
2008-01-24 19:33 ` [patch 02/26] mount options: add generic_show_options() Miklos Szeredi
2008-01-24 19:33 ` [patch 03/26] mount options: fix adfs Miklos Szeredi
2008-01-24 20:05 ` Russell King
2008-01-24 19:33 ` [patch 04/26] mount options: fix affs Miklos Szeredi
2008-01-24 19:33 ` [patch 05/26] mount options: fix afs Miklos Szeredi
2008-01-24 19:33 ` [patch 06/26] mount options: fix autofs4 Miklos Szeredi
2008-01-25 5:13 ` Ian Kent
2008-01-24 19:33 ` [patch 07/26] mount options: fix autofs Miklos Szeredi
2008-01-24 19:46 ` H. Peter Anvin
2008-01-24 19:33 ` [patch 08/26] mount options: fix befs Miklos Szeredi
2008-01-24 19:33 ` [patch 09/26] mount options: fix capifs Miklos Szeredi
2008-01-25 10:18 ` Karsten Keil
2008-01-24 19:33 ` [patch 10/26] mount options: fix devpts Miklos Szeredi
2008-01-24 19:46 ` H. Peter Anvin
2008-01-25 9:24 ` Miklos Szeredi
2008-01-24 19:33 ` [patch 11/26] mount options: fix ext2 Miklos Szeredi
2008-01-25 14:34 ` Jan Kara
2008-01-24 19:33 ` [patch 12/26] mount options: fix ext4 Miklos Szeredi
2008-01-25 6:41 ` Andreas Dilger
2008-01-25 14:37 ` Jan Kara
2008-01-25 17:35 ` Mingming Cao
2008-01-24 19:33 ` [patch 13/26] mount options: fix fat Miklos Szeredi
2008-01-24 19:33 ` [patch 14/26] mount options: fix fuse Miklos Szeredi
2008-01-24 19:33 ` [patch 15/26] mount options: fix hostfs Miklos Szeredi
2008-01-24 19:33 ` [patch 16/26] mount options: fix hpfs Miklos Szeredi
2008-01-24 19:33 ` [patch 17/26] mount options: fix hugetlbfs Miklos Szeredi
2008-01-24 19:33 ` [patch 18/26] mount options: fix isofs Miklos Szeredi
2008-01-25 14:42 ` Jan Kara
2008-01-24 19:34 ` [patch 19/26] mount options: fix jfs Miklos Szeredi
2008-01-24 21:15 ` Dave Kleikamp
2008-01-24 21:57 ` Andrew Morton
2008-01-24 22:17 ` Dave Kleikamp
2008-01-24 19:34 ` [patch 20/26] mount options: fix ncpfs Miklos Szeredi
2008-01-24 19:34 ` [patch 21/26] mount options: partially fix nfs Miklos Szeredi
2008-01-24 20:49 ` Chuck Lever
2008-01-25 9:39 ` Miklos Szeredi
2008-01-25 17:19 ` Chuck Lever
2008-01-28 11:34 ` Miklos Szeredi
2008-01-28 16:22 ` Chuck Lever
2008-01-24 20:53 ` Trond Myklebust
2008-01-25 9:43 ` Miklos Szeredi
2008-01-24 19:34 ` [patch 22/26] mount options: fix reiserfs Miklos Szeredi
2008-01-24 19:34 ` [patch 23/26] mount options: fix spufs Miklos Szeredi
2008-01-24 19:34 ` [patch 24/26] mount options: fix tmpfs Miklos Szeredi
2008-01-28 6:09 ` Hugh Dickins
2008-01-28 11:40 ` Miklos Szeredi
2008-01-29 13:28 ` Hugh Dickins
2008-01-24 19:34 ` [patch 25/26] mount options: fix udf Miklos Szeredi
2008-01-24 19:51 ` Cyrill Gorcunov
2008-01-24 20:20 ` Cyrill Gorcunov
2008-01-25 9:29 ` Miklos Szeredi
2008-01-25 10:57 ` Cyrill Gorcunov
2008-01-25 13:41 ` Cyrill Gorcunov [this message]
2008-01-25 15:27 ` Jan Kara
2008-01-25 15:50 ` Miklos Szeredi
2008-01-25 15:57 ` Cyrill Gorcunov
2008-01-25 16:07 ` Jan Kara
2008-01-25 16:10 ` Miklos Szeredi
2008-01-24 20:40 ` Cyrill Gorcunov
2008-01-25 15:30 ` Jan Kara
2008-01-25 15:56 ` Miklos Szeredi
2008-01-25 16:04 ` Jan Kara
2008-01-24 19:34 ` [patch 26/26] mount options: fix usbfs Miklos Szeredi
2008-01-24 22:01 ` Greg KH
2008-01-25 9:54 ` Miklos Szeredi
2008-01-27 6:01 ` [patch 00/26] mount options: fix filesystem's ->show_options Andrew Morton
2008-01-28 11:36 ` Miklos Szeredi
2008-01-29 0:19 ` [patch 05/26] mount options: fix afs David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080125134158.GA7233@cvg \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).