From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek Date: Mon, 28 Jan 2008 13:38:57 +0000 Message-ID: <20080128133857.6c53ac9f@core> References: <20080127317.043953000@suse.de> <20080127211345.6e73fa0b.akpm@linux-foundation.org> <20080128125605.299740a1@core> <200801281427.36048.ak@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Trond Myklebust , Steve French , swhiteho@redhat.com, sfrench@samba.org, vandrove@vc.cvut.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Andi Kleen Return-path: Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:35918 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1755188AbYA1Nog (ORCPT ); Mon, 28 Jan 2008 08:44:36 -0500 In-Reply-To: <200801281427.36048.ak@suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > Also worse really fixing it would be a major change to the VFS > because of the way ->read/write are defined :/ I don't see a problem there. ->read and ->write update the passed pointer which is not the real f_pos anyway. Just the copies need fixing. Alan