From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andi Kleen <ak@suse.de>
Subject: Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek
Date: Mon, 28 Jan 2008 15:10:34 +0100
Message-ID: <200801281510.35200.ak@suse.de>
References: <20080127317.043953000@suse.de> <200801281427.36048.ak@suse.de> <20080128133857.6c53ac9f@core>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Trond Myklebust <Trond.Myklebust@netapp.com>,
	Steve French <smfrench@gmail.com>, swhiteho@redhat.com,
	sfrench@samba.org, vandrove@vc.cvut.cz,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from ns.suse.de ([195.135.220.2]:54894 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751499AbYA1OKi (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 28 Jan 2008 09:10:38 -0500
In-Reply-To: <20080128133857.6c53ac9f@core>
Content-Disposition: inline
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Monday 28 January 2008 14:38:57 Alan Cox wrote:
> > Also worse really fixing it would be a major change to the VFS 
> > because of the way ->read/write are defined :/
> 
> I don't see a problem there. ->read and ->write update the passed pointer
> which is not the real f_pos anyway. Just the copies need fixing. 

They are effectually doing a decoupled read/modify/write cycle. e.g.:

A               B

read fpos       

                read fpos

fpos += A       fpos += B
                write fpos


write fpos

So you get overlapping reads. Probably not good.

-Andi