From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kentaro Takeda <takedakn@nttdata.co.jp>
Cc: linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org
Subject: Re: [RFC] Add vfsmount to vfs helper functions.
Date: Wed, 30 Jan 2008 13:00:06 +0000 [thread overview]
Message-ID: <20080130130006.GH27894@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4799B808.8080002@nttdata.co.jp>
On Fri, Jan 25, 2008 at 07:20:56PM +0900, Kentaro Takeda wrote:
> In the LSM ml, we are discussing about
> "how to know requested pathnames within LSM modules".
>
> Currently, VFS helper functions don't pass "struct vfsmount" parameter.
> Therefore, we cannot calculate requested pathnames within LSM modules
> because LSM hooks can't know "struct vfsmount" parameter that corresponds with
> "struct dentry" passed to VFS helper functions.
>
> AppArmor is proposing a patch that appends "struct vfsmount" parameters to
> VFS helper functions so that LSM modules (SELinux, AppArmor, TOMOYO) can
> calculate requested pathnames.
>
> The changes in include/linux/fs.h are shown below.
> What do you think about these changes?
That they are bloody *wrong*. You have not addressed any of the objections
that had been posted too many times to repeat. Damn it, you've not even
bothered to deal with the specific obvious stupidity with vfs_rename() -
just reposted the dreck and devil take all feedback. Wonderful...
next prev parent reply other threads:[~2008-01-30 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 10:20 [RFC] Add vfsmount to vfs helper functions Kentaro Takeda
2008-01-30 13:00 ` Al Viro [this message]
2008-02-02 14:23 ` Tetsuo Handa
2008-02-17 9:00 ` Tetsuo Handa
2008-02-17 23:38 ` Al Viro
2008-02-18 0:03 ` Tetsuo Handa
2008-02-18 0:40 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080130130006.GH27894@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=takedakn@nttdata.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).