From: Al Viro <viro@ZenIV.linux.org.uk>
To: Joel Schopp <jschopp@austin.ibm.com>
Cc: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>,
Tigran Aivazian <tigran@aivazian.fsnet.co.uk>,
trivial@kernel.org, linux-fsdevel@vger.kernel.org,
apw@shadowen.org, rdunlap@xenotime.net,
Linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 8/9] bfs: remove multiple assignments
Date: Wed, 30 Jan 2008 13:06:56 +0000 [thread overview]
Message-ID: <20080130130656.GI27894@ZenIV.linux.org.uk> (raw)
In-Reply-To: <479D7DEB.7070806@austin.ibm.com>
On Mon, Jan 28, 2008 at 01:02:03AM -0600, Joel Schopp wrote:
> >>>- inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC;
> >>>+ inode->i_mtime = CURRENT_TIME_SEC;
> >>>+ inode->i_atime = CURRENT_TIME_SEC;
> >>>+ inode->i_ctime = CURRENT_TIME_SEC;
> >>multiple assignments like "x = y = z = value;" can potentially
> >>(depending on the compiler and arch) be faster than "x = value; y =
> >>value; z=value;"
> >>
> >>I am surprized that this script complains about them as it is a
> >>perfectly valid thing to do in C.
> >
> >I think it seems wise to ask the maintainers of checkpatch.pl to
> >comment on that. I'm Cc:ing them now.
> >
>
> There are plenty of things that are valid to do in C that don't make for
> maintainable code. These scripts are designed to make your code easier for
> real people to review and maintain.
Except that in this case the new variant is not equivalent to the old one...
next prev parent reply other threads:[~2008-01-30 13:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 21:20 [PATCH v2 0/9] bfs: assorted cleanups Dmitri Vorobiev
2008-01-25 21:20 ` [PATCH v2 1/9] bfs: remove a useless variable Dmitri Vorobiev
2008-01-25 21:20 ` [PATCH v2 2/9] bfs: coding style cleanup in fs/bfs/inode.c Dmitri Vorobiev
2008-01-25 21:20 ` [PATCH v2 3/9] bfs: coding style cleanup in fs/bfs/bfs.h Dmitri Vorobiev
2008-01-25 21:20 ` [PATCH v2 4/9] bfs: coding style cleanup in fs/bfs/dir.c Dmitri Vorobiev
2008-01-25 21:20 ` [PATCH v2 5/9] bfs: move function prototype to the proper header file Dmitri Vorobiev
2008-01-25 21:20 ` [PATCH v2 6/9] bfs: coding style cleanup in fs/bfs/file.c Dmitri Vorobiev
2008-01-25 21:20 ` [PATCH v2 7/9] bfs: coding style cleanup in include/linux/bfs_fs.h Dmitri Vorobiev
2008-01-25 21:20 ` [PATCH v2 8/9] bfs: remove multiple assignments Dmitri Vorobiev
2008-01-26 18:35 ` Tigran Aivazian
2008-01-26 21:32 ` Dmitri Vorobiev
2008-01-26 23:48 ` Dmitri Vorobiev
2008-01-28 7:02 ` Joel Schopp
2008-01-30 13:06 ` Al Viro [this message]
2008-01-30 13:36 ` Dmitri Vorobiev
2008-01-27 14:08 ` Adrian Bunk
2008-01-27 14:39 ` Dmitri Vorobiev
2008-01-25 21:20 ` [PATCH v2 9/9] bfs: use the proper header file for inclusion Dmitri Vorobiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080130130656.GI27894@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=apw@shadowen.org \
--cc=dmitri.vorobiev@gmail.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=tigran@aivazian.fsnet.co.uk \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).