From: Christoph Hellwig <hch@lst.de>
To: jean-noel.cordenner@bull.net
Cc: linux-fsdevel@vger.kernel.org
Subject: i_version changes
Date: Sun, 10 Feb 2008 08:30:41 +0100 [thread overview]
Message-ID: <20080210073041.GA23529@lst.de> (raw)
I think the i_version changes that hit mainline about a week ago are
not as nice as they should be.
First there's a complete lack of documentation on this, which is very
bad. Please document what the new semantics for i_version on regular
files are supposed to be, and how it differes from the existing
semantics for directories.
Second abusing one of the rather scare superblock mount flags is
a bad idea. It would be much better to set this through ->setattr
and an extension of struct iattr. Especially as we need to convert
file_update_time to update c and mtime through ->setattr anyway.
Third using the MS_ flag but then actually having a filesystem
mount option to enable it is more than confusing. After all MS_
options (at least the exported parts) are the mount ABI for common
options. Also this option doesn't show up in ->show_options,
which is something Miklos will beat you up for :)
I'm also not convinced this should be option behaviour, either you
do update i_version for a given filesystem or you don't - having
an obscure mount option will only give you confusion.
Beyond those any good reason for making inode_inc_iversion inline,
especially after the first patch introduced it properly out of line.
And as a last note please stop pushing these kind of core changes
through specific filesystem trees. If this had been in ->mm we
would have caught this a lot earlier, and would have also meant you'd
get input and possible even implementations from other filesystem
maintainers.
next reply other threads:[~2008-02-10 7:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-10 7:30 Christoph Hellwig [this message]
2008-02-12 20:06 ` i_version changes J. Bruce Fields
2008-02-13 9:25 ` Andreas Dilger
2008-02-13 12:52 ` Christoph Hellwig
2008-02-13 14:07 ` Trond Myklebust
2008-02-13 15:12 ` Andreas Dilger
2008-02-13 20:26 ` J. Bruce Fields
2008-02-13 21:19 ` NeilBrown
2008-02-13 21:32 ` Peter Staubach
2008-02-13 22:06 ` NeilBrown
2008-02-14 14:34 ` Peter Staubach
2008-02-14 8:40 ` Jean noel Cordenner
2008-02-14 14:38 ` Peter Staubach
2008-02-15 10:31 ` Jean noel Cordenner
2008-02-13 21:36 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080210073041.GA23529@lst.de \
--to=hch@lst.de \
--cc=jean-noel.cordenner@bull.net \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).