From: Christoph Hellwig <hch@infradead.org>
To: Steve French <smfrench@gmail.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: remove some of cifs hard to read ifdefs
Date: Wed, 13 Feb 2008 02:05:43 -0500 [thread overview]
Message-ID: <20080213070543.GB3301@infradead.org> (raw)
In-Reply-To: <524f69650802121325k1d9e88c4ndcf41962923dd337@mail.gmail.com>
On Tue, Feb 12, 2008 at 03:25:49PM -0600, Steve French wrote:
> On Feb 7, 2008 12:25 PM, Christoph Hellwig <hch@infradead.org> wrote:
> > and while I'm at it a lot of the non-DFS additions to cifs aren't quite
> > up to standards for kernel code either, lots of useless braces, wierd
> > coding style and ifdef mania.
> The useless braces should be removed now. The "ifdef mania" should be
> cut by about a quarter by the following patch (following up on the
> patch idea posted late last week):
>
> http://git.kernel.org/?p=linux/kernel/git/sfrench/cifs-2.6.git;a=commitdiff;h=90c81e0b0eda214196cbe4340facbce8cc797ee7
Thanks, this starts to look a lot better.
prev parent reply other threads:[~2008-02-13 7:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 21:25 remove some of cifs hard to read ifdefs Steve French
2008-02-13 7:05 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080213070543.GB3301@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).