* remove some of cifs hard to read ifdefs
@ 2008-02-12 21:25 Steve French
2008-02-13 7:05 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Steve French @ 2008-02-12 21:25 UTC (permalink / raw)
To: linux-fsdevel
On Feb 7, 2008 12:25 PM, Christoph Hellwig <hch@infradead.org> wrote:
> and while I'm at it a lot of the non-DFS additions to cifs aren't quite
> up to standards for kernel code either, lots of useless braces, wierd
> coding style and ifdef mania.
The useless braces should be removed now. The "ifdef mania" should be
cut by about a quarter by the following patch (following up on the
patch idea posted late last week):
http://git.kernel.org/?p=linux/kernel/git/sfrench/cifs-2.6.git;a=commitdiff;h=90c81e0b0eda214196cbe4340facbce8cc797ee7
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: remove some of cifs hard to read ifdefs
2008-02-12 21:25 remove some of cifs hard to read ifdefs Steve French
@ 2008-02-13 7:05 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2008-02-13 7:05 UTC (permalink / raw)
To: Steve French; +Cc: linux-fsdevel
On Tue, Feb 12, 2008 at 03:25:49PM -0600, Steve French wrote:
> On Feb 7, 2008 12:25 PM, Christoph Hellwig <hch@infradead.org> wrote:
> > and while I'm at it a lot of the non-DFS additions to cifs aren't quite
> > up to standards for kernel code either, lots of useless braces, wierd
> > coding style and ifdef mania.
> The useless braces should be removed now. The "ifdef mania" should be
> cut by about a quarter by the following patch (following up on the
> patch idea posted late last week):
>
> http://git.kernel.org/?p=linux/kernel/git/sfrench/cifs-2.6.git;a=commitdiff;h=90c81e0b0eda214196cbe4340facbce8cc797ee7
Thanks, this starts to look a lot better.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-13 7:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-12 21:25 remove some of cifs hard to read ifdefs Steve French
2008-02-13 7:05 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).