From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Dilger Subject: Re: i_version changes Date: Wed, 13 Feb 2008 02:25:38 -0700 Message-ID: <20080213092538.GY3029@webber.adilger.int> References: <20080210073041.GA23529@lst.de> <20080212200625.GE18625@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT Cc: Christoph Hellwig , jean-noel.cordenner@bull.net, linux-fsdevel@vger.kernel.org To: "J. Bruce Fields" Return-path: Received: from sca-es-mail-2.Sun.COM ([192.18.43.133]:40324 "EHLO sca-es-mail-2.sun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932619AbYBMJZn (ORCPT ); Wed, 13 Feb 2008 04:25:43 -0500 Received: from fe-sfbay-09.sun.com ([192.18.43.129]) by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m1D9PevV008475 for ; Wed, 13 Feb 2008 01:25:40 -0800 (PST) Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JW600E017ES9L00@fe-sfbay-09.sun.com> (original mail from adilger@sun.com) for linux-fsdevel@vger.kernel.org; Wed, 13 Feb 2008 01:25:40 -0800 (PST) In-reply-to: <20080212200625.GE18625@fieldses.org> Content-disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Feb 12, 2008 15:06 -0500, J. Bruce Fields wrote: > On Sun, Feb 10, 2008 at 08:30:41AM +0100, Christoph Hellwig wrote: > > Third using the MS_ flag but then actually having a filesystem > > mount option to enable it is more than confusing. After all MS_ > > options (at least the exported parts) are the mount ABI for common > > options. Also this option doesn't show up in ->show_options, > > which is something Miklos will beat you up for :) > > I'm also not convinced this should be option behaviour, either you > > do update i_version for a given filesystem or you don't - having > > an obscure mount option will only give you confusion. > > That does sound likely to be confusing. Any chance we could just make > the new behavior mandatory? One of the reasons NOT to make it mandatory is that it forces updates of the inode after every write. On ext3/ext4 this is expensive, as the ext3_dirty_inode() packs the inode from memory into the buffer each time, so that it can be journaled. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc.