From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [RFC 01/11] add generic versions of debugfs file operations Date: Sun, 24 Feb 2008 10:00:18 -0800 Message-ID: <20080224180018.GA13234@suse.de> References: <20080219040435.825494460@arndb.de> <20080219040828.415218298@arndb.de> <20080223122444.GM27894@ZenIV.linux.org.uk> <200802241146.08360.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , David Howells To: Arnd Bergmann Return-path: Received: from cantor.suse.de ([195.135.220.2]:58662 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759392AbYBXSBI (ORCPT ); Sun, 24 Feb 2008 13:01:08 -0500 Content-Disposition: inline In-Reply-To: <200802241146.08360.arnd@arndb.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Feb 24, 2008 at 11:46:07AM +0100, Arnd Bergmann wrote: > On Saturday 23 February 2008, Al Viro wrote: > > > Ewww - caps, \n... BTW, \0 is pointless here - simple_read_from_buffer() will > > not access it with these arguments)... > > > ... > > > Please, check the length; sloppy input grammar is a bad idea. Hell, at the > > very least you want -EINVAL if input is not recognized... > > Ok, these two come straight from debugfs, but of course I can fix them > anyway. Should I do a fix for debugfs in 2.6.25 first, or rather do a > patch on top of the libfs rework? I'll gladly take a patch to debugfs for it :) thanks, greg k-h