From: "Adam J. Richter" <adam@yggdrasil.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: Patch: romfs_lookup always failed in linux-2.6.25-rc3-git3
Date: Tue, 4 Mar 2008 10:19:31 -0800 [thread overview]
Message-ID: <20080304181931.GA24301@freya.fugue.com> (raw)
In-Reply-To: <20080304012621.b84fc769.akpm@linux-foundation.org>
On Tue, Mar 04, 2008 at 01:26:21AM -0800, Andrew Morton wrote:
> On Mon, 3 Mar 2008 09:36:20 -0800 "Adam J. Richter" <adam@yggdrasil.com> wrote:
[...]
> > P.S. romfs_lookup casts a valid pointer to an int and then back again
> > with res = PTR_ERR(inode);...return ERR_PTR(res). This may break on
> > arhictectures where sizeof(int) < sizeof(pointer). If I want to submit
> > a subsequent fix for this, are you the person I should the patch to?
Oops, please ignore my incorrect "P.S.". As David Howells has
explained, the PTR_ERR(inode) call is only done when inode is known to
contain an error code, so it should be safe on all architectures.
Sorry for the false alarm about that part.
Adam
next prev parent reply other threads:[~2008-03-04 18:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 17:36 Patch: romfs_lookup always failed in linux-2.6.25-rc3-git3 Adam J. Richter
2008-03-04 9:26 ` Andrew Morton
2008-03-04 18:19 ` Adam J. Richter [this message]
2008-03-04 14:32 ` David Howells
2008-03-04 18:40 ` Adam J. Richter
2008-03-04 22:25 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080304181931.GA24301@freya.fugue.com \
--to=adam@yggdrasil.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).