From: Andreas Dilger <adilger@sun.com>
To: Akira Fujita <a-fujita@rs.jp.nec.com>
Cc: tytso@mit.edu, cmm@us.ibm.com, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][PATCH 2/3] ext4 online defrag (ver 0.7)
Date: Wed, 05 Mar 2008 22:25:52 -0700 [thread overview]
Message-ID: <20080306052552.GL3616@webber.adilger.int> (raw)
In-Reply-To: <200803060001.AA00324@TNESG9526.rs.jp.nec.com>
On Mar 06, 2008 09:01 +0900, Akira Fujita wrote:
> Change the name of functions (ext4_ext_xxx -> ext4_defrag_xxx)
> and some cleanups.
>
> -int ext4_ext_walk_space(struct inode *inode, ext4_lblk_t block,
> - ext4_lblk_t num, ext_prepare_callback func,
> - void *cbdata)
> -{
We were just going to be using this function for the FIEMAP support.
I think there are several other functions which are not specific
to defrag, so they shouldn't be renamed to be defrag specific.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2008-03-06 5:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 0:01 [RFC][PATCH 2/3] ext4 online defrag (ver 0.7) Akira Fujita
2008-03-06 5:25 ` Andreas Dilger [this message]
2008-03-06 6:20 ` Akira Fujita
2008-03-06 16:36 ` Eric Sandeen
2008-03-06 23:46 ` Akira Fujita
2008-03-08 2:13 ` Re:[PATCH 3/5] ext4: online defrag -- Move the file data to the new blocks Mingming Cao
2008-03-18 9:39 ` [RFC][PATCH 2/3] ext4 online defrag (ver 0.7) Solofo.Ramangalahy
-- strict thread matches above, loose matches on Subject: below --
2008-03-19 1:05 Akira Fujita
2008-03-19 1:40 Akira Fujita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080306052552.GL3616@webber.adilger.int \
--to=adilger@sun.com \
--cc=a-fujita@rs.jp.nec.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).