From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/2] LSM/SELinux: inode_{get,set}secctx hooks to access LSM security context information. Date: Fri, 7 Mar 2008 11:03:53 +0100 Message-ID: <20080307100353.GA16831@lst.de> References: <1204743288-3461-1-git-send-email-dpquigl@tycho.nsa.gov> <1204743288-3461-3-git-send-email-dpquigl@tycho.nsa.gov> <20080306123013.GB4648@lst.de> <1204811422.1397.205.camel@moss-spartans.epoch.ncsc.mil> <20080306135444.GA5216@infradead.org> <1204812304.1397.213.camel@moss-spartans.epoch.ncsc.mil> <20080306140713.GA20087@infradead.org> <1204814886.1397.244.camel@moss-spartans.epoch.ncsc.mil> <1204823638.14520.202.camel@moss-terrapins.epoch.ncsc.mil> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Stephen Smalley , James Morris , Christoph Hellwig , Christoph Hellwig , casey@schaufler-ca.com, chrisw@sous-sol.org, viro@zeniv.linux.org.uk, selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Dave Quigley Return-path: Received: from verein.lst.de ([213.95.11.210]:43960 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756981AbYCGKEd (ORCPT ); Fri, 7 Mar 2008 05:04:33 -0500 Content-Disposition: inline In-Reply-To: <1204823638.14520.202.camel@moss-terrapins.epoch.ncsc.mil> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Mar 06, 2008 at 12:13:58PM -0500, Dave Quigley wrote: > So are we keeping the dentry parameter for these calls, or am I changing > them over to an inode. If it is going to use an inode this means I need > to change the parameters for the xattr code. Is there a reason why the > xattr code takes dentries instead of an inode? Ah, that's the reason why you use dentries. Either keep the dentry in the call that does the xattr modification for now and document that why you're doing it, or if you feel eager fix up the xattr interface. In fact the new fine-grained xattr interface already only passed inodes which is what the inode operations should have been doing aswell - xattrs are a concept tied to the inode and not in any way to a hiearchical pathname component.