From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [linux-cifs-client] review 5, was Re: projected date for mount.cifs to support DFS junction points Date: Sat, 8 Mar 2008 13:43:45 -0500 Message-ID: <20080308184345.GB1461@infradead.org> References: <1199988975.7483.3.camel@gn2.draper.com> <524f69650801101228o3639363cp4c9710d747b71ead@mail.gmail.com> <20080111090749.GA14910@infradead.org> <524f69650801110805y56cdbe4nf7587e396b70f32c@mail.gmail.com> <20080113202144.GB24573@infradead.org> <47B5BFCF.60304@mail.ru> <20080215170552.GA27584@infradead.org> <524f69650802151302h4e631a74pe382ca932cc85c7@mail.gmail.com> <20080215221158.GA15021@infradead.org> <524f69650802251225m1ce0b31dj9b5f7fe6314272ef@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , "Q (Igor Mammedov)" , linux-fsdevel , linux-cifs-client@lists.samba.org To: Steve French Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:38986 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753280AbYCHSnr (ORCPT ); Sat, 8 Mar 2008 13:43:47 -0500 Content-Disposition: inline In-Reply-To: <524f69650802251225m1ce0b31dj9b5f7fe6314272ef@mail.gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Feb 25, 2008 at 02:25:50PM -0600, Steve French wrote: > On Fri, Feb 15, 2008 at 4:11 PM, Christoph Hellwig wrote: > > If you like these kind of consolidation patches here's another one: > > Merged into cifs-2.6.git tree Okay, now that we have the basic consolidation in can I get you to review force_uid_gid paramter to cifs_unix_info_to_inode? It seems more than fishy to me to ignore the CIFS_MOUNT_OVERR_{UID,GID} options in cifs_get_inode_info_unix but not in posix_fill_in_inode. This seems more like a missed propagation of changes for a newly added feature to me. If not it should at least get some documentation.