From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [RFC PATCH v2] vfs: optimization to /proc/<pid>/mountinfo patch
Date: Mon, 10 Mar 2008 03:10:46 -0400
Message-ID: <20080310071046.GA23574@infradead.org>
References: <E1JRr2R-0005CJ-D4@pomaz-ex.szeredi.hu> <20080220160422.GY27894@ZenIV.linux.org.uk> <E1JRrml-0005M9-Gi@pomaz-ex.szeredi.hu> <1203535754.28525.14.camel@ram.us.ibm.com> <20080220211421.GZ27894@ZenIV.linux.org.uk> <E1JRwax-0006Ah-8f@pomaz-ex.szeredi.hu> <E1JSZAc-0001Kk-MK@pomaz-ex.szeredi.hu> <1205132015.15345.87.camel@ram.us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Miklos Szeredi <miklos@szeredi.hu>, viro@ZenIV.linux.org.uk,
	linux-fsdevel@vger.kernel.org
To: Ram Pai <linuxram@us.ibm.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:41722 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750703AbYCJHKw (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 10 Mar 2008 03:10:52 -0400
Content-Disposition: inline
In-Reply-To: <1205132015.15345.87.camel@ram.us.ibm.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sun, Mar 09, 2008 at 11:53:34PM -0700, Ram Pai wrote:
> 1) reports deleted inode in dentry_path() consistent with that in __d_path()
> 2) modified __d_path() to use prepend(), reducing the size of __d_path()
> 3) moved all the functionality that reports mount information in /proc under
> 	CONFIG_PROC_FS.

I think that latter one goes to far, mnt_id and mn_pdid are generally
useful information that should be generated unconditionally.  That will
also get rid of most of the ifdef clutter introduced in this patch.