From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: Re: set last write time = fsync ? Date: Fri, 14 Mar 2008 12:55:26 -0400 Message-ID: <20080314125526.002fc2e5@tleilax.poochiereds.net> References: <524f69650803122054t7b0f8285kd564271f8340378e@mail.gmail.com> <20080313071046.1a9350a9@tleilax.poochiereds.net> <524f69650803131932w91fa962i261a4c72a99db9d8@mail.gmail.com> <20080314064017.6aa3e471@tleilax.poochiereds.net> <524f69650803140916w1dde16a9ja9dc4e052edd77e5@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-cifs-client@lists.samba.org, "Guenter Kukkukk" , linux-fsdevel To: "Steve French" Return-path: Received: from mx1.redhat.com ([66.187.233.31]:54331 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754366AbYCNQzh (ORCPT ); Fri, 14 Mar 2008 12:55:37 -0400 In-Reply-To: <524f69650803140916w1dde16a9ja9dc4e052edd77e5@mail.gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 14 Mar 2008 11:16:41 -0500 "Steve French" wrote: > I don't worry about flushing atime (anyone crazy enough to do that > would pay a huge performance penalty). > Access is usually checked on open right ... so once a file is open > even if the file becomes read-only, the writes, even cached writes > continue. > Ahh, you're correct. I've been doing a lot of NFS work lately and was thinking stateless... :-) That patch should be OK then, though I think if someone is purposefully setting the atime we should take care not to clobber it. We're not going to be going through this codepath on every atime update, are we? Just on utimes() type calls, correct? If so, doing a flush on atime updates might be reasonable as well... -- Jeff Layton