From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [patch 7/7] vfs: mountinfo: show dominating group id
Date: Wed, 26 Mar 2008 22:51:12 +0000
Message-ID: <20080326225112.GW10722@ZenIV.linux.org.uk>
References: <20080326211131.705321084@szeredi.hu> <20080326212144.764829833@szeredi.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: akpm@linux-foundation.org, linuxram@us.ibm.com,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Miklos Szeredi <miklos@szeredi.hu>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1756817AbYCZWv3@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20080326212144.764829833@szeredi.hu>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wed, Mar 26, 2008 at 10:11:38PM +0100, Miklos Szeredi wrote:
> +static struct vfsmount *get_peer_under_root(struct vfsmount *mnt,
> +					    struct mnt_namespace *ns,

Isn't it mnt->mnt_ns in all cases?

> +int get_dominator_id_same_root(struct vfsmount *mnt, const struct path *root)

Open season for better name.  Leaving aside .au associations, it's too
long and too uninformative...   Will do for now, but we'd better come up
with something better.