From: Arnd Bergmann <arnd@arndb.de>
To: Bob Copeland <me@bobcopeland.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/7] omfs: add inode routines
Date: Fri, 28 Mar 2008 04:42:45 +0100 [thread overview]
Message-ID: <200803280442.45974.arnd@arndb.de> (raw)
In-Reply-To: <1206578760-9050-2-git-send-email-me@bobcopeland.com>
On Thursday 27 March 2008, Bob Copeland wrote:
> +static struct inode *omfs_alloc_inode(struct super_block *sb)
> +{
> + struct omfs_inode_info *oinf;
> + oinf = (struct omfs_inode_info *) kmem_cache_alloc(omfs_inode_cachep,
> + GFP_KERNEL);
> + if (!oinf)
> + return NULL;
> + return &oinf->vfs_inode;
> +}
If you could avoid the i_state member in omfs_inode_info, you could get
rid of your own inode cache entirely. Your i_state seems to be mostly
write-only, why is it needed in your file system?
Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-03-28 3:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-27 0:45 [PATCH 2/7] omfs: add inode routines Bob Copeland
2008-03-27 6:13 ` Andi Kleen
2008-03-27 12:38 ` Bob Copeland
2008-03-28 3:42 ` Arnd Bergmann [this message]
2008-03-28 13:34 ` Bob Copeland
2008-03-28 20:20 ` Pavel Machek
2008-03-30 3:21 ` Bob Copeland
-- strict thread matches above, loose matches on Subject: below --
2008-04-12 22:58 Bob Copeland
2008-04-13 8:05 ` Christoph Hellwig
2008-04-13 9:17 ` Alan Cox
2008-04-15 18:03 ` Miklos Szeredi
2008-04-15 18:33 ` Bob Copeland
2008-04-15 18:30 ` Marcin Slusarz
2008-04-15 23:56 ` Bob Copeland
2008-04-16 18:31 ` Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803280442.45974.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).