From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: fs_stack/eCryptfs: remove 3rd arg of copy_attr_all, add locking to copy_inode_size Date: Wed, 2 Apr 2008 19:26:33 -0700 Message-ID: <20080402192633.722bec28.akpm@linux-foundation.org> References: <200804030149.m331nBCv005555@agora.fsl.cs.sunysb.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro , hch@infradead.org To: Erez Zadok Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:38111 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758660AbYDCC1U (ORCPT ); Wed, 2 Apr 2008 22:27:20 -0400 In-Reply-To: <200804030149.m331nBCv005555@agora.fsl.cs.sunysb.edu> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 2 Apr 2008 21:49:11 -0400 Erez Zadok wrote: > Andrew, this patch has been in my git tree for a while. It affects current > mainline users (i.e., ecryptfs). Do you think it can go to mainline soon? > If not, post-25? (I can remind you then). This patch has a few changes, and > I can break it into several smaller ones if desired: > > 1. remove the 3rd arg to fsstack_copy_attr_all. There are no users for it: > ecryptfs never used the 3rd arg; unionfs stopped using it a long time > ago. Halcrow ok'ed this patch some time ago. > > 2. add necessary locking for 32-bit smp systems in fsstack_copy_inode_size > (courtesy Hugh Dickins). > > 3. minor commenting style changes, and addition of copyrights which were > missing. > > Thanks, > Erez. > > --cut--here----cut--here----cut--here----cut--here----cut--here-- > > > fs_stack/eCryptfs: remove 3rd arg of copy_attr_all, add locking to copy_inode_size I'm already carrying this, via git-unionfs. It makes it a bit hard to merge. I guess resending it during the 2.6.26 merge window would suit.