From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 4/7] XFS: Return case-insensitive match for dentry cache Date: Thu, 3 Apr 2008 10:56:38 -0400 Message-ID: <20080403145638.GA3373@infradead.org> References: <20080402062508.017738664@chook.melbourne.sgi.com> <20080402062708.654277049@chook.melbourne.sgi.com> <20080403052209.GR103491721@sgi.com> <20080403164120.87e2e44b.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Chinner , Barry Naujok , xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org To: Stephen Rothwell Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:41177 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757304AbYDCO4s (ORCPT ); Thu, 3 Apr 2008 10:56:48 -0400 Content-Disposition: inline In-Reply-To: <20080403164120.87e2e44b.sfr@canb.auug.org.au> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Apr 03, 2008 at 04:41:20PM +1100, Stephen Rothwell wrote: > I haven't really been following this, but I was wondering if this could > be made generic and used in the CIFS code as well. They currently (I > think) have an awefull hack where they update the name in the dentry > (which throws a warning about dropping a const attribute in the memcpy). yes, it should. the new lookup higher level code added here should probably be a helper in dcache.c although that'll need a new abstraction for the unicode table handling.