From: Christoph Hellwig <hch@infradead.org>
To: Mingming Cao <cmm@us.ibm.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-fsdevel@vger.kernel.org, Duane Griffin <duaneg@dghda.com>
Subject: Re: [PATCH] fix up thinko in jbd2 revoke code
Date: Thu, 3 Apr 2008 12:17:27 -0400 [thread overview]
Message-ID: <20080403161727.GA627@infradead.org> (raw)
In-Reply-To: <1206988258.3653.2.camel@localhost.localdomain>
On Mon, Mar 31, 2008 at 11:30:58AM -0700, Mingming Cao wrote:
> On Mon, 2008-03-31 at 10:57 -0500, James Bottomley wrote:
> > This commit:
> >
> > commit e898f3154d78d1520265aade0992981866d827fb
> > Author: Duane Griffin <duaneg@dghda.com>
> > Date: Tue Mar 25 19:47:39 2008 -0400
> >
> > jbd2: tidy up revoke cache initialisation and destruction
> >
> > Introduced a thinko (it doesn't check whether jbd2_revoke_record cache
> > is null, it checks jbd2_revoke_table_cache twice).
> >
> > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> >
> Signed-off-by: Mingming Cao <cmm@us.ibm.com>
>
> Thanks, I picked this up in ext4 patch queue.
anyone care to convert this function to proper goto-based error
unwinding?
next prev parent reply other threads:[~2008-04-03 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-31 15:57 [PATCH] fix up thinko in jbd2 revoke code James Bottomley
2008-03-31 18:30 ` Mingming Cao
2008-04-03 16:17 ` Christoph Hellwig [this message]
2008-04-21 9:54 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080403161727.GA627@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=cmm@us.ibm.com \
--cc=duaneg@dghda.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).